Fix magento version compatibility issue (#779)

* Fix magento version compatibility issue

* Initialize ObjectManager

* Fix static test warnings

* Add line break

---------

Co-authored-by: Pradeep Kanaka <[email protected]>
Co-authored-by: Pradeep Kanaka <[email protected]>

Author: 3 people

app/code/Meta/BusinessExtension/Model/System/Message/ConflictingModulesNotification.php

@@ -9,60 +9,94 @@
 
 class ConflictingModulesNotification implements MessageInterface
 {
-
     /**
      * @var MetaIssueNotification
      */
     private MetaIssueNotification $metaIssueNotification;
+
     /**
      * @var ModuleManager
      */
     private ModuleManager $moduleManager;
 
+    /**
+     * @var array
+     */
     private static array $conflictingModules = ['Apptrian_MetaPixelApi'];
+
+    /**
+     * @var string
+     */
     private static string $meta_business_extension = 'Meta_BusinessExtension';
+
+    /**
+     * @var string
+     */
     private string $conflictingModulesFound = '';
 
+    /**
+     * ConflictingModulesNotification constructor.
+     *
+     * @param MetaIssueNotification $metaIssueNotification
+     * @param ModuleManager $moduleManager
+     */
     public function __construct(
         MetaIssueNotification      $metaIssueNotification,
         ModuleManager $moduleManager
     ) {
         $this->metaIssueNotification = $metaIssueNotification;
         $this->moduleManager = $moduleManager;
     }
+
+    /**
+     * Get identity
+     *
+     * @return string
+     */
     public function getIdentity()
     {
         $notification = $this->metaIssueNotification->loadVersionNotification();
         return $notification['notification_id'] ?? '';
     }
 
+    /**
+     * Validate if any conflicting modules are found
+     *
+     * @return bool
+     */
     public function isDisplayed()
     {
-
         //find out if the user enabled the Meta Business Extension
         $has_Meta_BusinessExtension = $this->moduleManager->isEnabled(self::$meta_business_extension);
 
         //iterate through the user's module manager to see if they have any conflicting modules
-        foreach(self::$conflictingModules as $conflictingModule) {
-            if ($this->moduleManager->isEnabled($conflictingModule) && $has_Meta_BusinessExtension)
-            {
+        foreach (self::$conflictingModules as $conflictingModule) {
+            if ($this->moduleManager->isEnabled($conflictingModule) && $has_Meta_BusinessExtension) {
                 $this->conflictingModulesFound = $conflictingModule;
                 return true;
             }
         }
         return false;
     }
 
-
+    /**
+     * Get text
+     *
+     * @return string
+     */
     public function getText()
     {
-        return sprintf( 'The following module conflicts with the Facebook & Instagram Extension: [%s] . Please disable the conflicting module.',
-            $this->conflictingModulesFound);
+        return sprintf('The following module conflicts with the Facebook & Instagram Extension: [%s].
+            Please disable the conflicting module.', $this->conflictingModulesFound);
     }
 
+    /**
+     * Get severity
+     *
+     * @return int
+     */
     public function getSeverity()
     {
         return self::SEVERITY_CRITICAL;
     }
-
-}
+}

app/code/Meta/Catalog/Plugin/FacebookCatalogUpdateFullReindexPlugin.php

@@ -22,10 +22,9 @@
 
 use Meta\Catalog\Model\ResourceModel\FacebookCatalogUpdate as FBCatalogUpdateResourceModel;
 use Magento\Indexer\Model\Indexer;
-use Magento\Framework\Mview\View\ChangelogBatchWalker;
-use Magento\Framework\Mview\View\ChangelogBatchWalkerFactory;
 use Magento\Framework\Mview\View;
 use Magento\Indexer\Model\WorkingStateProvider;
+use Magento\Framework\ObjectManagerInterface;
 
 class FacebookCatalogUpdateFullReindexPlugin
 {
@@ -40,30 +39,30 @@ class FacebookCatalogUpdateFullReindexPlugin
     private $fbCatalogUpdateResourceModel;
 
     /**
-     * @var ChangelogBatchWalkerFactory
+     * @var WorkingStateProvider
      */
-    private $changelogBatchWalkerFactory;
+    private $workingStateProvider;
 
     /**
-     * @var WorkingStateProvider
+     * @var ObjectManagerInterface
      */
-    private $workingStateProvider;
+    private $objectManager;
 
     /**
      * FacebookCatalogUpdateOnIndexerPlugin constructor
      *
      * @param WorkingStateProvider $workingStateProvider
      * @param FBCatalogUpdateResourceModel $fbCatalogUpdateResourceModel
-     * @param ChangelogBatchWalkerFactory $changelogBatchWalkerFactory
+     * @param ObjectManagerInterface $objectManager
      */
     public function __construct(
         WorkingStateProvider         $workingStateProvider,
         FBCatalogUpdateResourceModel $fbCatalogUpdateResourceModel,
-        ChangelogBatchWalkerFactory  $changelogBatchWalkerFactory
+        ObjectManagerInterface  $objectManager
     ) {
         $this->workingStateProvider = $workingStateProvider;
         $this->fbCatalogUpdateResourceModel = $fbCatalogUpdateResourceModel;
-        $this->changelogBatchWalkerFactory = $changelogBatchWalkerFactory;
+        $this->objectManager = $objectManager;
     }
 
     /**
@@ -85,7 +84,7 @@ public function beforeReindexAll(Indexer $subject)
         $nextVersionId = $cl->getVersion();
 
         while ($currentVersionId < $nextVersionId) {
-            $walker = $this->changelogBatchWalkerFactory->create(ChangelogBatchWalker::class);
+            $walker = $this->getChangelogBatchWalkerInstance();
             $batches = $walker->walk($cl, $currentVersionId, $nextVersionId, $batchSize);
 
             foreach ($batches as $ids) {
@@ -98,6 +97,27 @@ public function beforeReindexAll(Indexer $subject)
         }
     }
 
+    /**
+     * Get class object
+     */
+    public function getChangelogBatchWalkerInstance()
+    {
+        if (class_exists(\Magento\Framework\Mview\View\ChangeLogBatchWalkerFactory::class)) { // @phpstan-ignore-line
+            $changeLogWalkerFactory = $this->objectManager->create(
+                \Magento\Framework\Mview\View\ChangeLogBatchWalkerFactory::class // @phpstan-ignore-line
+            );
+            return $changeLogWalkerFactory->create(
+                \Magento\Framework\Mview\View\ChangeLogBatchWalker::class // @phpstan-ignore-line
+            );
+        }
+        $changelogWalkerFactory = $this->objectManager->create(
+            \Magento\Framework\Mview\View\ChangelogBatchWalkerFactory::class // @phpstan-ignore-line
+        );
+        return $changelogWalkerFactory->create(
+            \Magento\Framework\Mview\View\ChangelogBatchWalker::class // @phpstan-ignore-line
+        );
+    }
+
     /**
      * Checks to run the catalog update plugin
      *