Symbol's function definition is void: magit-highlight-bracket-keywords

[kjnez]

When calling forge-visit-issue, I got the following warning in the echo area:

Symbol's function definition is void: magit-highlight-bracket-keywords

Here's the backtrace:

Debugger entered--Lisp error: (void-function magit-highlight-bracket-keywords)
transient--exit-and-debug(error (void-function magit-highlight-bracket-keywords))
magit-highlight-bracket-keywords()
#f(compiled-function (%) #<bytecode -0x1a2989944aef9e85>)(magit-highlight-bracket-keywords)
run-hook-wrapped(#f(compiled-function (%) #<bytecode -0x1a2989944aef9e85>) magit-highlight-bracket-keywords)
forge--format-topic-title(#)
forge--format-topic-line(#)
#f(compiled-function (%) #<bytecode 0xc1d746fbf830e20>)(#)
mapcar(#f(compiled-function (%) #<bytecode 0xc1d746fbf830e20>) (# # # # # # # # # # #))
forge--topic-collection((# # # # # # # # # # #))
forge--read-topic("View topic" forge-current-topic # #)
forge-read-topic("View topic")
byte-code("\300\301!C\207" [forge-read-topic "View topic"] 2)
eval((byte-code "\300\301!C\207" [forge-read-topic "View topic"] 2))
advice-eval-interactive-spec((byte-code "\300\301!C\207" [forge-read-topic "View topic"] 2))
#f(compiled-function (spec) #<bytecode 0x1ea7b2873bcaaf12>)((byte-code "\300\301!C\207" [forge-read-topic "View topic"] 2))
funcall(#f(compiled-function (spec) #<bytecode 0x1ea7b2873bcaaf12>) (byte-code "\300\301!C\207" [forge-read-topic "View topic"] 2))
command-execute(forge-visit-topic)

The expected behavior is that I should be able to view the topic and the minibuffer will allow me to select a topic to view.

I'm currently bypassing this problem through
(remove-hook 'forge-topic-wash-title-hook #'magit-highlight-bracket-keywords)

Version:
Magit 4.5.0, Transient 0.12.0, Forge 20260208.1639, Git 2.47.3, Emacs 30.2

Same problem with lastest Forge on melpa-stable.

[tarsius]

I cannot reproduce this. I even made sure that Forge and Magit were not loaded before invoking the, at this point still autoloaded, forge-visit-topic using M-x.

This function was added over a year ago, and so far nobody else had this issue. The most likely cause is that you have multiple versions of an involved package (likely Magit) installed and the outdated version is being loaded. Check if that is the case.

I also recommend the re-installation dance.

1. Remove magit and forge.
2. Exit Emacs.
3. Start Emacs.
4. Re-install the removed packages.

[kjnez]

I deleted magit, magit-section and forge, and then installed them again. Evaluating (list (featurep 'magit-diff) (featurep 'forge-commands)) did return (t t). Evaluating forge-visit-topic works fine. After restarting Emacs, evaluating (list (featurep 'magit-diff) (featurep 'forge-commands)) still returns (t t), but evaluating forge-visit-topic now gives

Symbol's function definition is void: magit-highlight-bracket-keywords

[tarsius]

So we have established that using forge-visit-topic causes magit-diff to be loaded (if it isn't loaded already anyway).

magit-diff.el does define magit-highlight-bracket-keywords. You are using Magit 4.5.0. Here is that function in that release:

https://github.com/magit/magit/blob/c800f79c2061621fde847f6a53129eca0e8da728/lisp/magit-diff.el#L2902-L2907

I don't know what's wrong but it very much looks like this is something specific to your machine. Maybe a different version of magit-diff.el is being loaded. Maybe something does (fmakunbound 'magit-highlight-bracket-keywords). Maybe something that isn't magit-diff.el does (provide 'magit-diff).

I'm afraid I cannot help you more with this. Sorry.

[kjnez]

Thanks. I'll figure it out and let you know what's really wrong.

[kjnez]

I figured it out by running M-x list-load-path-shadows.

It seems git-commit-4.1.3 is shadowing magit-4.5.0 and magit-section-4.5.0. Earlier you asked me to check load-path, but I wasn't even aware the existence of this outdated package since the name is so unfamiliar.

/home/j/.emacs.d/elpa/git-commit-4.1.3/magit-files hides /home/j/.emacs.d/elpa/magit-4.5.0/magit-files
/home/j/.emacs.d/elpa/git-commit-4.1.3/magit-process hides /home/j/.emacs.d/elpa/magit-4.5.0/magit-process
/home/j/.emacs.d/elpa/git-commit-4.1.3/git-commit hides /home/j/.emacs.d/elpa/magit-4.5.0/git-commit
/home/j/.emacs.d/elpa/git-commit-4.1.3/magit-reset hides /home/j/.emacs.d/elpa/magit-4.5.0/magit-reset
/home/j/.emacs.d/elpa/git-commit-4.1.3/magit-tag hides /home/j/.emacs.d/elpa/magit-4.5.0/magit-tag
/home/j/.emacs.d/elpa/git-commit-4.1.3/magit hides /home/j/.emacs.d/elpa/magit-4.5.0/magit
/home/j/.emacs.d/elpa/git-commit-4.1.3/magit-stash hides /home/j/.emacs.d/elpa/magit-4.5.0/magit-stash
/home/j/.emacs.d/elpa/git-commit-4.1.3/magit-fetch hides /home/j/.emacs.d/elpa/magit-4.5.0/magit-fetch
/home/j/.emacs.d/elpa/git-commit-4.1.3/magit-push hides /home/j/.emacs.d/elpa/magit-4.5.0/magit-push
/home/j/.emacs.d/elpa/git-commit-4.1.3/magit-gitignore hides /home/j/.emacs.d/elpa/magit-4.5.0/magit-gitignore
/home/j/.emacs.d/elpa/git-commit-4.1.3/magit-mode hides /home/j/.emacs.d/elpa/magit-4.5.0/magit-mode
/home/j/.emacs.d/elpa/git-commit-4.1.3/magit-merge hides /home/j/.emacs.d/elpa/magit-4.5.0/magit-merge
/home/j/.emacs.d/elpa/git-commit-4.1.3/magit-refs hides /home/j/.emacs.d/elpa/magit-4.5.0/magit-refs
/home/j/.emacs.d/elpa/git-commit-4.1.3/magit-git hides /home/j/.emacs.d/elpa/magit-4.5.0/magit-git
/home/j/.emacs.d/elpa/git-commit-4.1.3/magit-apply hides /home/j/.emacs.d/elpa/magit-4.5.0/magit-apply
/home/j/.emacs.d/elpa/git-commit-4.1.3/magit-pull hides /home/j/.emacs.d/elpa/magit-4.5.0/magit-pull
/home/j/.emacs.d/elpa/git-commit-4.1.3/magit-reflog hides /home/j/.emacs.d/elpa/magit-4.5.0/magit-reflog
/home/j/.emacs.d/elpa/git-commit-4.1.3/magit-commit hides /home/j/.emacs.d/elpa/magit-4.5.0/magit-commit
/home/j/.emacs.d/elpa/git-commit-4.1.3/magit-wip hides /home/j/.emacs.d/elpa/magit-4.5.0/magit-wip
/home/j/.emacs.d/elpa/git-commit-4.1.3/magit-diff hides /home/j/.emacs.d/elpa/magit-4.5.0/magit-diff
/home/j/.emacs.d/elpa/git-commit-4.1.3/magit-ediff hides /home/j/.emacs.d/elpa/magit-4.5.0/magit-ediff
/home/j/.emacs.d/elpa/git-commit-4.1.3/magit-core hides /home/j/.emacs.d/elpa/magit-4.5.0/magit-core
/home/j/.emacs.d/elpa/git-commit-4.1.3/magit-extras hides /home/j/.emacs.d/elpa/magit-4.5.0/magit-extras
/home/j/.emacs.d/elpa/git-commit-4.1.3/magit-notes hides /home/j/.emacs.d/elpa/magit-4.5.0/magit-notes
/home/j/.emacs.d/elpa/git-commit-4.1.3/magit-submodule hides /home/j/.emacs.d/elpa/magit-4.5.0/magit-submodule
/home/j/.emacs.d/elpa/git-commit-4.1.3/magit-repos hides /home/j/.emacs.d/elpa/magit-4.5.0/magit-repos
/home/j/.emacs.d/elpa/git-commit-4.1.3/magit-bundle hides /home/j/.emacs.d/elpa/magit-4.5.0/magit-bundle
/home/j/.emacs.d/elpa/git-commit-4.1.3/magit-status hides /home/j/.emacs.d/elpa/magit-4.5.0/magit-status
/home/j/.emacs.d/elpa/git-commit-4.1.3/magit-patch hides /home/j/.emacs.d/elpa/magit-4.5.0/magit-patch
/home/j/.emacs.d/elpa/git-commit-4.1.3/magit-blame hides /home/j/.emacs.d/elpa/magit-4.5.0/magit-blame
/home/j/.emacs.d/elpa/git-commit-4.1.3/magit-worktree hides /home/j/.emacs.d/elpa/magit-4.5.0/magit-worktree
/home/j/.emacs.d/elpa/git-commit-4.1.3/magit-transient hides /home/j/.emacs.d/elpa/magit-4.5.0/magit-transient
/home/j/.emacs.d/elpa/git-commit-4.1.3/magit-log hides /home/j/.emacs.d/elpa/magit-4.5.0/magit-log
/home/j/.emacs.d/elpa/git-commit-4.1.3/magit-branch hides /home/j/.emacs.d/elpa/magit-4.5.0/magit-branch
/home/j/.emacs.d/elpa/git-commit-4.1.3/git-rebase hides /home/j/.emacs.d/elpa/magit-4.5.0/git-rebase
/home/j/.emacs.d/elpa/git-commit-4.1.3/magit-bisect hides /home/j/.emacs.d/elpa/magit-4.5.0/magit-bisect
/home/j/.emacs.d/elpa/git-commit-4.1.3/magit-remote hides /home/j/.emacs.d/elpa/magit-4.5.0/magit-remote
/home/j/.emacs.d/elpa/git-commit-4.1.3/magit-subtree hides /home/j/.emacs.d/elpa/magit-4.5.0/magit-subtree
/home/j/.emacs.d/elpa/git-commit-4.1.3/magit-clone hides /home/j/.emacs.d/elpa/magit-4.5.0/magit-clone
/home/j/.emacs.d/elpa/git-commit-4.1.3/magit-bookmark hides /home/j/.emacs.d/elpa/magit-4.5.0/magit-bookmark
/home/j/.emacs.d/elpa/git-commit-4.1.3/magit-base hides /home/j/.emacs.d/elpa/magit-4.5.0/magit-base
/home/j/.emacs.d/elpa/git-commit-4.1.3/magit-margin hides /home/j/.emacs.d/elpa/magit-4.5.0/magit-margin
/home/j/.emacs.d/elpa/git-commit-4.1.3/magit-sequence hides /home/j/.emacs.d/elpa/magit-4.5.0/magit-sequence
/home/j/.emacs.d/elpa/git-commit-4.1.3/magit-sparse-checkout hides /home/j/.emacs.d/elpa/magit-4.5.0/magit-sparse-checkout
/home/j/.emacs.d/elpa/git-commit-4.1.3/magit-autorevert hides /home/j/.emacs.d/elpa/magit-4.5.0/magit-autorevert
/home/j/.emacs.d/elpa/git-commit-4.1.3/magit-section hides /home/j/.emacs.d/elpa/magit-section-4.5.0/magit-section

[tarsius]

I figured it out by running M-x list-load-path-shadows.

I have to remember to suggest that command. Thanks for the reminder.

git-commit.el is maintained in the magit repository, but used to be distributed as a separate package. Now it is distributed with magit. That package should never have contained any magit*.el libraries, but apparently something had gone wrong with packaging.