feat: remove relay functionality from autonomi network #3262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
|
|
||
| /// The shared recorders that are used to record metrics. | ||
| #[allow(dead_code)] // TODO: Remove this once we have removed all the deprecated metrics related to relay. |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
maqi
requested changes
Oct 22, 2025
Member
There was a problem hiding this comment.
Better got this PR having its own PR descriptions to cover what changed and what aimed for.
Also, seems there is some outdated stuff in the PR description of PR 3116.
For example, it says:
- ✅ Remove relay CLI options (--relay flag)
BUT, in the PR 3262 code change, the flag remains, though it does nothing.
Better to update to sync.
Put in Request Changes, as it needs sepecific testnet runs to confirm the work, before got merged in.
This commit systematically removes libp2p relay functionality from the Autonomi network, transitioning to a network architecture that relies solely on direct QUIC connections and UPnP for NAT traversal. Changes include: - Remove "relay" feature from libp2p dependencies in Cargo.toml - Remove relay_client field from NetworkConfig and NodeBuilder - Simplify transport layer to use only QUIC (remove relay transport) - Remove relay behaviors (relay_client, relay_server) from NodeBehaviour - Remove RelayManager and connected_relay_clients from SwarmDriver - Remove all relay event handling from swarm events - Remove relay-specific metrics and monitoring - Delete relay_manager.rs and relay_client.rs metrics files - Remove relay CLI options and Python bindings - Update UPnP to be enabled by default for non-local nodes - Remove relay peer tracking and related statistics - Simplify identify event handling to remove relay address crafting This is a breaking change that simplifies the codebase and improves direct peer-to-peer communication by removing relay bottlenecks. Nodes behind restrictive NATs will need to rely on UPnP for connectivity. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- This is a non-breaking change as the NodeRegistry is unaffected
RolandSherwin
force-pushed
the
disable_relay
branch
from
da1ce94 to
fa009a6
Compare
RolandSherwin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relay client & server behaviourfrom the node and client--relayflag from antctl--relayflag inside antnode as a no-op to not break older service definition files