feat(bootstrap): split Bootstrap::new method into two #3268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
RolandSherwin
force-pushed
the
reach/1_bootstrap_changes
branch
2 times, most recently
from
3039575 to
233f482
Compare
integration - Split the `async fn Bootstrap::new` method into two methods, where the `new` is made a "sync" method and `async fn new_with_preloaded_addrs` retains the same functionality as the old new method. - The `new_with_preloaded_addrs` method is only required inside clients which tries to pre-populate its RT before starting the libp2p driver. - Introduces `is_addr_queue_empty`, as it will be used by the reachability check implementation - Deprecate `try_next_dial_addr` as it is just a copy of `next_addr`
RolandSherwin
force-pushed
the
reach/1_bootstrap_changes
branch
from
233f482 to
c4f5a73
Compare
There was a problem hiding this comment.
devskim found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
async fn Bootstrap::newmethod into two methods, where thenewis made a "sync" method andasync fn new_with_preloaded_addrsretains the same functionality as the old new method.new_with_preloaded_addrsmethod is only required inside clients which tries to pre-populate its RT before starting the libp2p driver.is_addr_queue_empty, as it will be used by the reachability check implementationtry_next_dial_addras it is just a copy ofnext_addr