Skip to content

Commit 72bb94f

Browse files
committed
feat: replace delete_log with rollover_on_start
Signed-off-by: Patrick Gehrsitz <github@mryel.de>
1 parent b1a38de commit 72bb94f

4 files changed

Lines changed: 9 additions & 6 deletions

File tree

crowsnest/camera/types/uvc.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,9 +35,7 @@ def __init__(self, path: str, *args, **kwargs) -> None:
3535
cur_sec = name
3636
self.control_values[cur_sec] = {}
3737
continue
38-
self.control_values[cur_sec][name] = v4l2.ctl.parse_qc_of_path(
39-
self.path, qc
40-
)
38+
self.control_values[cur_sec][name] = parsed_qc
4139
self.formats = v4l2.ctl.get_formats(self.path)
4240

4341
def get_formats_string(self) -> str:

crowsnest/components/crowsnest.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ def parse_config_section(self, section: SectionProxy) -> None:
2424
self.parameters.update(
2525
{
2626
"log_level": section.getloglevel("log_level", "INFO"),
27-
"delete_log": section.getboolean("delete_log", False),
27+
"rollover_on_start": section.getboolean("rollover_on_start", False),
2828
"no_proxy": section.getboolean("no_proxy", False),
2929
}
3030
)

crowsnest/crowsnest.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,11 @@
1212
import argparse
1313
import asyncio
1414
import configparser
15+
import os
1516
import signal
1617
import time
1718
import traceback
19+
from logging.handlers import RotatingFileHandler
1820

1921
from crowsnest import logger, logging_helper, utils, watchdog
2022
from crowsnest.components.crowsnest import Crowsnest
@@ -166,8 +168,11 @@ async def main():
166168
logger.log_error("Something went terribly wrong!")
167169
exit(1)
168170

169-
if crowsnest.parameters["delete_log"]:
171+
if crowsnest.parameters["rollover_on_start"]:
170172
logger.logger.handlers.clear()
173+
for h in logger.logger.handlers:
174+
if isinstance(h, RotatingFileHandler):
175+
h.doRollover()
171176
logger.setup_logging(args.log_path, "w")
172177
logging_helper.log_initial()
173178

resources/crowsnest.conf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727

2828
[crowsnest]
2929
log_level: verbose # Valid Options are quiet/verbose/debug
30-
delete_log: false # Deletes log on every restart, if set to true
30+
rollover_on_start: false # Creates a backup and clears the log on every restart, if set to true
3131
no_proxy: false # If set to true, no reverse proxy is required. Only change this, if you know what you are doing.
3232

3333
[cam 1]

0 commit comments

Comments
 (0)