Skip to content

Commit 3324747

Browse files
committed
UX: Improve account association when account description is missing
1 parent 1922d4b commit 3324747

File tree

2 files changed

+11
-4
lines changed

2 files changed

+11
-4
lines changed

app/assets/javascripts/discourse/templates/modal/associate-account-confirm.hbs

+8-3
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,14 @@
1010
</div>
1111
{{/if}}
1212

13-
{{i18n "user.associated_accounts.confirm_description"
14-
provider=(i18n (concat "login." model.provider_name ".name"))
15-
account_description=model.account_description}}
13+
{{#if model.account_description}}
14+
{{i18n "user.associated_accounts.confirm_description.account_specific"
15+
provider=(i18n (concat "login." model.provider_name ".name"))
16+
account_description=model.account_description}}
17+
{{else}}
18+
{{i18n "user.associated_accounts.confirm_description.generic"
19+
provider=(i18n (concat "login." model.provider_name ".name"))}}
20+
{{/if}}
1621
{{/d-modal-body}}
1722

1823
<div class="modal-footer">

config/locales/client.en.yml

+3-1
Original file line numberDiff line numberDiff line change
@@ -1024,7 +1024,9 @@ en:
10241024
cancel: "Cancel"
10251025
not_connected: "(not connected)"
10261026
confirm_modal_title: "Connect %{provider} Account"
1027-
confirm_description: "Your %{provider} account '%{account_description}' will be used for authentication."
1027+
confirm_description:
1028+
account_specific: "Your %{provider} account '%{account_description}' will be used for authentication."
1029+
generic: "Your %{provider} account will be used for authentication."
10281030

10291031
name:
10301032
title: "Name"

0 commit comments

Comments
 (0)