Bug 1965844 - Part 3: Don't overwrite a pending exception in Array.prototype.with. r=jandem

marco-c · marco-c · commit 4f22f4eb6510 · 2025-05-14T13:43:14.000Z
Test case in <tc39/test262#4477>. Differential Revision: https://phabricator.services.mozilla.com/D248928 UltraBlame original commit: 1c03eb73265d4c6d57cff099c3f00aaced99075f
diff --git a/js/src/builtin/Array.cpp b/js/src/builtin/Array.cpp
@@ -3761,7 +3761,6 @@ static bool array_with(JSContext* cx, unsigned argc, Value* vp) {
   
   double relativeIndex;
   if (!ToInteger(cx, args.get(0), &relativeIndex)) {
-    JS_ReportErrorNumberASCII(cx, GetErrorMessage, nullptr, JSMSG_BAD_INDEX);
     return false;
   }
 

Original file line number	Diff line number	Diff line change
`@@ -3761,7 +3761,6 @@ static bool array_with(JSContext* cx, unsigned argc, Value* vp) {`
`3761`	`3761`
`3762`	`3762`	`double relativeIndex;`
`3763`	`3763`	`if (!ToInteger(cx, args.get(0), &relativeIndex)) {`
`3764`		`- JS_ReportErrorNumberASCII(cx, GetErrorMessage, nullptr, JSMSG_BAD_INDEX);`
`3765`	`3764`	`return false;`
`3766`	`3765`	`}`
`3767`	`3766`