Bug 1965844 - Part 3: Don't overwrite a pending exception in Array.prototype.with. r=jandem

marco-c · marco-c · commit 1ab214df9c9e · 2025-05-14T14:04:33.000Z
Test case in <tc39/test262#4477>. Differential Revision: https://phabricator.services.mozilla.com/D248928 UltraBlame original commit: 4c54c405baf8acea20927e66c1dc6e9b88c25b25
diff --git a/js/src/builtin/Array.cpp b/js/src/builtin/Array.cpp
@@ -24389,25 +24389,10 @@ true
 }
 /
 /
-https
-:
-/
-/
-github
-.
-com
-/
-tc39
-/
-proposal
--
-change
--
-array
--
-by
--
-copy
+ES2026
+draft
+rev
+a562082b031d89d00ee667181ce8a6158656bd4b
 /
 /
 Array
@@ -24416,6 +24401,8 @@ prototype
 .
 with
 (
+index
+value
 )
 static
 bool
@@ -24561,14 +24548,6 @@ relativeIndex
 )
 )
 {
-JS_ReportErrorNumberASCII
-(
-cx
-GetErrorMessage
-nullptr
-JSMSG_BAD_INDEX
-)
-;
 return
 false
 ;
diff --git a/js/src/jit-test/tests/errors/bug-1886940.js b/js/src/jit-test/tests/errors/bug-1886940.js
@@ -7,7 +7,7 @@ test
 |
 error
 :
-RangeError
+TypeError
 [
 ]
 .

Original file line number	Diff line number	Diff line change
`@@ -24389,25 +24389,10 @@ true`
`24389`	`24389`	`}`
`24390`	`24390`	`/`
`24391`	`24391`	`/`
`24392`		`-https`
`24393`		`-:`
`24394`		`-/`
`24395`		`-/`
`24396`		`-github`
`24397`		`-.`
`24398`		`-com`
`24399`		`-/`
`24400`		`-tc39`
`24401`		`-/`
`24402`		`-proposal`
`24403`		`--`
`24404`		`-change`
`24405`		`--`
`24406`		`-array`
`24407`		`--`
`24408`		`-by`
`24409`		`--`
`24410`		`-copy`
	`24392`	`+ES2026`
	`24393`	`+draft`
	`24394`	`+rev`
	`24395`	`+a562082b031d89d00ee667181ce8a6158656bd4b`
`24411`	`24396`	`/`
`24412`	`24397`	`/`
`24413`	`24398`	`Array`
`@@ -24416,6 +24401,8 @@ prototype`
`24416`	`24401`	`.`
`24417`	`24402`	`with`
`24418`	`24403`	`(`
	`24404`	`+index`
	`24405`	`+value`
`24419`	`24406`	`)`
`24420`	`24407`	`static`
`24421`	`24408`	`bool`
`@@ -24561,14 +24548,6 @@ relativeIndex`
`24561`	`24548`	`)`
`24562`	`24549`	`)`
`24563`	`24550`	`{`
`24564`		`-JS_ReportErrorNumberASCII`
`24565`		`-(`
`24566`		`-cx`
`24567`		`-GetErrorMessage`
`24568`		`-nullptr`
`24569`		`-JSMSG_BAD_INDEX`
`24570`		`-)`
`24571`		`-;`
`24572`	`24551`	`return`
`24573`	`24552`	`false`
`24574`	`24553`	`;`
Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@ test`
`7`	`7`	`\|`
`8`	`8`	`error`
`9`	`9`	`:`
`10`		`-RangeError`
	`10`	`+TypeError`
`11`	`11`	`[`
`12`	`12`	`]`
`13`	`13`	`.`