Skip to content

GH#17503: restore MERGE_SUMMARY compliance — executable template, contract V3, continuation prompt#17519

Merged
marcusquinn merged 1 commit intomainfrom
bugfix/merge-summary-compliance
Apr 6, 2026
Merged

GH#17503: restore MERGE_SUMMARY compliance — executable template, contract V3, continuation prompt#17519
marcusquinn merged 1 commit intomainfrom
bugfix/merge-summary-compliance

Conversation

@marcusquinn
Copy link
Copy Markdown
Owner

Summary

  • Restores the executable gh pr comment template in full-loop.md step 4.2.1 (removed by simplification commit 738e4ca49)
  • Adds MERGE_SUMMARY to the headless contract V3 pre-exit self-check with exact verification command
  • Adds MERGE_SUMMARY reminder to the continuation prompt sent when workers stop prematurely

Root Cause

Two-factor regression causing 65% MERGE_SUMMARY miss rate (13 of 20 recent PRs):

  1. Simplification (738e4ca49) compressed a full executable code block with template into a single prose line. Workers went from having a copy-paste command to a compressed instruction competing with 15+ other mandatory steps.

  2. Continuation gap: Neither the headless contract pre-exit check nor the continuation prompt mentioned MERGE_SUMMARY. Workers that stop after PR creation (natural model stopping point) are never reminded about this step.

Evidence: PRs before simplification (17030, 17017, 17324) had 100% MERGE_SUMMARY rate. Post-simplification rate dropped to ~35%.

Changes

  • .agents/scripts/commands/full-loop.md — restore gh pr comment code block with template + add verification command
  • .agents/scripts/headless-runtime-helper.sh — contract V2→V3 (add MERGE_SUMMARY to pre-exit checklist), continuation prompt (add MERGE_SUMMARY reminder)

Defense in Depth

This PR complements #17517 (already merged) which added PR body text as a fallback source for _extract_merge_summary. Together:

Layer What Coverage
Instruction (this PR) Executable template + pre-exit check + continuation reminder Targets 100% compliance
Fallback (#17517) Extract from PR body when comment missing Catches remaining misses
Generic (existing) "Neither MERGE_SUMMARY comment nor PR body text was available" Near-zero expected

Closes #17503

… V3, continuation prompt (GH#17503)

Two-factor root cause for 65% MERGE_SUMMARY miss rate:
1. Simplification (738e4ca) compressed the executable gh pr comment template
   into a single prose line — workers stopped following it
2. Neither the headless contract pre-exit check nor the continuation prompt
   mentioned MERGE_SUMMARY — workers that stopped after PR creation were
   never reminded

Three fixes:
- full-loop.md: restore the copy-paste gh pr comment command with template
  and add a verification command
- headless contract V2→V3: add MERGE_SUMMARY to the pre-exit self-check
  checklist with the exact verification command
- continuation prompt: explicitly remind about MERGE_SUMMARY after PR creation
@gemini-code-assist
Copy link
Copy Markdown

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 6, 2026

Warning

Rate limit exceeded

@marcusquinn has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 8 minutes and 41 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 8 minutes and 41 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 5e2bb110-d4dc-4649-9ebc-32acd8a23688

📥 Commits

Reviewing files that changed from the base of the PR and between c35d454 and 0f640d1.

📒 Files selected for processing (2)
  • .agents/scripts/commands/full-loop.md
  • .agents/scripts/headless-runtime-helper.sh
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bugfix/merge-summary-compliance

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 6, 2026

🔍 Code Quality Report

�[0;35m[MONITOR]�[0m Code Review Monitoring Report

SonarCloud: 0 bugs, 0 vulnerabilities, 1 code smells

Mon Apr 6 01:21:49 UTC 2026: Code review monitoring started
Mon Apr 6 01:21:49 UTC 2026: SonarCloud - Bugs: 0, Vulnerabilities: 0, Code Smells: 1

📈 Current Quality Metrics

  • BUGS: 0
  • CODE SMELLS: 1
  • VULNERABILITIES: 0

Generated on: Mon Apr 6 01:21:52 UTC 2026


Generated by AI DevOps Framework Code Review Monitoring

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 6, 2026

@marcusquinn marcusquinn merged commit 768f3f3 into main Apr 6, 2026
27 of 31 checks passed
@marcusquinn
Copy link
Copy Markdown
Owner Author

Completed via PR #17519, merged to main.

Merged by deterministic merge pass (pulse-wrapper.sh). No worker summary was available — the worker either crashed before writing one or this PR predates the merge summary convention.

aidevops.sh v3.6.113 spent 5m on this as a headless bash routine.

@codacy-production
Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

TIP This summary will be updated as you push new changes. Give us feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

t1896: Resolve specific model name in dispatch comments instead of auto-select (round-robin)

1 participant