You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently in v4 if a region is destroyed the view the region belongs to will not trigger the remove:region event. They are only triggered if view.removeRegion(name) is used. All that method does is trigger the events and destroy the region.
It seems minor, but inconsistent.
Seems like _removeReferences and the remove events could be triggered off of the region's destroy event. Of course that means adding a listener for each region instance which is less than ideal.
The text was updated successfully, but these errors were encountered:
I tend to agree. I can't come up with any scenario. Worth looking to maybe deprecate them and remove them for v5. I was mainly making this issue to document the inconsistency
Went back in history and it looks like this event was primarily internal and was for the region manager to talk with the view or app. Probably safe to deprecate it.
Currently in v4 if a region is
destroyed
the view the region belongs to will not trigger theremove:region
event. They are only triggered ifview.removeRegion(name)
is used. All that method does is trigger the events and destroy the region.It seems minor, but inconsistent.
Seems like
_removeReferences
and the remove events could be triggered off of the region's destroy event. Of course that means adding a listener for each region instance which is less than ideal.The text was updated successfully, but these errors were encountered: