Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove:region events are not triggered if a view's region is destroyed #3602

Open
paulfalgout opened this issue May 10, 2018 · 3 comments
Open
Milestone

Comments

@paulfalgout
Copy link
Member

Currently in v4 if a region is destroyed the view the region belongs to will not trigger the remove:region event. They are only triggered if view.removeRegion(name) is used. All that method does is trigger the events and destroy the region.

It seems minor, but inconsistent.

Seems like _removeReferences and the remove events could be triggered off of the region's destroy event. Of course that means adding a listener for each region instance which is less than ideal.

@blikblum
Copy link
Collaborator

Wondering if there any real use case for remove:region, add:region events.

When i looked at it i could not think of an actual usage scenario

@paulfalgout
Copy link
Member Author

I tend to agree. I can't come up with any scenario. Worth looking to maybe deprecate them and remove them for v5. I was mainly making this issue to document the inconsistency

@paulfalgout
Copy link
Member Author

Went back in history and it looks like this event was primarily internal and was for the region manager to talk with the view or app. Probably safe to deprecate it.

@paulfalgout paulfalgout added this to the v5 milestone Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants