Skip to content
This repository has been archived by the owner on Dec 20, 2023. It is now read-only.

Modal background stay after close #237

Open
elchiconube opened this issue Nov 22, 2022 · 1 comment · May be fixed by #239
Open

Modal background stay after close #237

elchiconube opened this issue Nov 22, 2022 · 1 comment · May be fixed by #239
Assignees

Comments

@elchiconube
Copy link

When I call <Modal /> component and pass the prop open with false the background block de UI. You need to click to remove it

@elchiconube
Copy link
Author

I cannot create a Pull request so here's the fix proposal. Just change the JSX template adding <dialog /> tag inside open conditional rendering

  return (
    open && (
      <dialog className={cx('ola_modal', variant && `is-${variant}`, { 'is-closable': closable }, className)} {...props} ref={modal} onClick={clickOutside}>
      ...
      </dialog>
    )
  )

@elchiconube elchiconube linked a pull request Jan 12, 2023 that will close this issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants