fix(tests): prepared for evaluation

Author: marplyn

src/test/java/loanservice/negative/CreateOrderNegativeTest.java

@@ -8,12 +8,22 @@ public class CreateOrderNegativeTest {
     private final LoanServiceSteps loanServiceSteps = new LoanServiceSteps();
 
     @Test
-    void postCreateOrderNegative() {
+    void postCreateOrderInvalidTariffTest() {
         Long userId = 420356955L;
         Integer tariffId = 25;
         CreateOrderRequest createOrderRequest = new CreateOrderRequest(userId, tariffId);
         loanServiceSteps.postCreateOrder(createOrderRequest)
                 .responseStatusShouldBeEqualTo(400)
                 .postCreateOrderShouldHaveError();
     }
+
+    @Test
+    void postCreateOrderEmptyTest() {
+        Long userId = null;
+        Integer tariffId = null;
+        CreateOrderRequest createOrderRequest = new CreateOrderRequest(userId, tariffId);
+        loanServiceSteps.postCreateOrder(createOrderRequest)
+                .responseStatusShouldBeEqualTo(400)
+                .postCreateOrderShouldHaveError();
+    }
 }

src/test/java/loanservice/negative/DeleteOrderNegativeTest.java

@@ -2,6 +2,7 @@
 
 import api.models.DeleteOrderRequest;
 import api.steps.LoanServiceSteps;
+import org.junit.jupiter.api.Test;
 import org.junit.jupiter.params.ParameterizedTest;
 import org.junit.jupiter.params.provider.CsvSource;
 
@@ -13,7 +14,17 @@ public class DeleteOrderNegativeTest {
             "123456, 720a4b3f-e8d6-4896-b854-4aa5c1946756",
             "233568957, 7275fe6b-b5b4-49fb-9ddc-4c90121776dc"
     })
-    void postCreateOrderNegative(Long userId, String orderId) {
+    void deleteOrderInvalidParamsTest(Long userId, String orderId) {
+        DeleteOrderRequest deleteOrderRequest = new DeleteOrderRequest(userId, orderId);
+        loanServiceSteps.deleteOrder(deleteOrderRequest)
+                .responseStatusShouldBeEqualTo(400)
+                .deleteOrderShouldBeFailed();
+    }
+
+    @Test
+    void deleteOrderEmptyTest() {
+        Long userId = null;
+        String orderId = null;
         DeleteOrderRequest deleteOrderRequest = new DeleteOrderRequest(userId, orderId);
         loanServiceSteps.deleteOrder(deleteOrderRequest)
                 .responseStatusShouldBeEqualTo(400)

src/test/java/loanservice/negative/GetStatusOrderNegativeTest.java

@@ -1,6 +1,7 @@
 package loanservice.negative;
 
 import api.steps.LoanServiceSteps;
+import org.junit.jupiter.api.Test;
 import org.junit.jupiter.params.ParameterizedTest;
 import org.junit.jupiter.params.provider.ValueSource;
 
@@ -9,7 +10,7 @@ public class GetStatusOrderNegativeTest {
 
     @ParameterizedTest
     @ValueSource(strings = {"84fa0932-3a29-4b1e-885e-11546cb59708", "739926c1-09e9-492b-ab3d-08e39ff6a5a4"})
-    void getStatusOrderNegative(String orderId) {
+    void getStatusOrderInvalidParamsTest(String orderId) {
         loanServiceSteps.getStatusOrder(orderId)
                 .responseStatusShouldBeEqualTo(400)
                 .getStatusOrderShouldBeFailed();

src/test/java/loanservice/positive/CreateOrderTest.java

@@ -15,7 +15,7 @@ public class CreateOrderTest {
             "4653785, 3",
             "120356894755, 1"
     })
-    void postCreateOrderPositive(Long userId, Integer tariffId) {
+    void postCreateOrderTest(Long userId, Integer tariffId) {
         CreateOrderRequest createOrderRequest = new CreateOrderRequest(userId, tariffId);
         loanServiceSteps.postCreateOrder(createOrderRequest)
                 .responseStatusShouldBeEqualTo(200)

src/test/java/loanservice/positive/DeleteOrderTest.java

@@ -14,10 +14,10 @@ public class DeleteOrderTest {
 
     @ParameterizedTest
     @CsvSource({
-            "525489, 720a4b3f-e8d6-4896-b854-4aa5c1946756",
-            "233568957, 399926c1-09e9-492b-ab3d-48e39ff6a5a4"
+            "453156, 6be658df-8dc9-4846-85f0-bc72d1c13105",
+            "90653785, f5ca3f42-0f57-4552-aa40-b6a314d47943"
     })
-    void postCreateOrderPositive(Long userId, String orderId) {
+    void deleteOrderTest(Long userId, String orderId) {
         DeleteOrderRequest deleteOrderRequest = new DeleteOrderRequest(userId, orderId);
         loanServiceSteps.deleteOrder(deleteOrderRequest)
                 .responseStatusShouldBeEqualTo(200);

src/test/java/loanservice/positive/GetStatusOrderTest.java

@@ -8,7 +8,7 @@ public class GetStatusOrderTest {
     private final LoanServiceSteps loanServiceSteps = new LoanServiceSteps();
 
     @ParameterizedTest
-    @ValueSource(strings = {"399926c1-09e9-492b-ab3d-48e39ff6a5a4", "f4fa0932-3a29-4b1e-885e-11546cb51704"})
+    @ValueSource(strings = {"ace41169-c147-4be4-8492-518125aa1c0a", "f5ca3f42-0f57-4552-aa40-b6a314d47943"})
     void getStatusOrderPositive(String orderId) {
         loanServiceSteps.getStatusOrder(orderId)
                 .responseStatusShouldBeEqualTo(200)