Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

narray 0.6.0.8 test fails #37

Open
graaff opened this issue May 9, 2013 · 6 comments
Open

narray 0.6.0.8 test fails #37

graaff opened this issue May 9, 2013 · 6 comments

Comments

@graaff
Copy link

graaff commented May 9, 2013

With ruby 1.8.7 (2012-10-12 patchlevel 371) [x86_64-linux] I'm getting the following test failure:

..... the next will fail .....
$a.rot90                       
test/testreverse.rb:5:in `px': ./lib/narray_ext.rb:267:in `rot90': must be >= 2 dimensional array (RuntimeError)
    from (eval):1:in `px'
    from test/testreverse.rb:26:in `eval'
    from test/testreverse.rb:5:in `px'
    from test/testreverse.rb:26
@masa16
Copy link
Owner

masa16 commented May 9, 2013

See the first line you copied.

@graaff
Copy link
Author

graaff commented May 9, 2013

So you are saying that the test suite should crash and have an exit code of 1? That makes it more difficult to use a CI system which always expects a clean run. You can't catch this exception and test it?

@masa16
Copy link
Owner

masa16 commented May 9, 2013

This is a legacy test code before unit test became popular. Now it should be rewritten as Spec...

@graaff
Copy link
Author

graaff commented May 9, 2013

Aha, now I see what is going on. We already comment out the other similar tests for Gentoo's test phase, but this one has different wording. Ok, I'll handle this on the Gentoo side.

@graaff graaff closed this as completed May 9, 2013
@graaff
Copy link
Author

graaff commented May 9, 2013

Now that I'm past this problem I'm also seeing

test/testcomplex.rb:13:in `<main>': undefined method `im' for 0.25:Float (NoMethodError)

@graaff graaff reopened this May 9, 2013
@masa16
Copy link
Owner

masa16 commented May 9, 2013

Fixed. c56dc59
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants