Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

destructive non-bang methods #38

Open
dunric opened this issue May 18, 2013 · 0 comments
Open

destructive non-bang methods #38

dunric opened this issue May 18, 2013 · 0 comments

Comments

@dunric
Copy link

dunric commented May 18, 2013

There is a misconception with the following instance methods:

fill vs fill! and indgen vs indgen!

In current implementation the former ones are just aliases to the latter, which is quite confusing and against not only basic ruby naming conventions but also in contradiction to other NArray methods naming like collect/collect!, newdim/newdim!, newrank/newrank! or flatten/flatten!.

I'd suggest fill and indgen have to either call their non-destructive function versions or be rather completely removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant