Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

paginated responses #37

Open
krzee opened this issue Jan 9, 2023 · 2 comments
Open

paginated responses #37

krzee opened this issue Jan 9, 2023 · 2 comments

Comments

@krzee
Copy link

krzee commented Jan 9, 2023

My uptimerobot monitor has 243 servers, but i only ingest 50 of them. This seems to be due to pagination. Do I need to do something to support pagination? Is it a bug?

@krzee
Copy link
Author

krzee commented Jan 9, 2023

When I hit the API by hand i see:
{"stat":"ok","pagination":{"offset":0,"limit":50,"total":243},
but when I look at logs from the exporter scraping I see:
level=info msg="Response from UptimeRobot API%!(EXTRA *api.XMLMonitors=&{{{ pagination} 0 0 0}

@masaruhoshi
Copy link
Owner

Hi @krzee.
Thanks for the feedback. I actually have refactored a few parts of the exporter that I plan to have merged soon. It includes expanding the pagination support. I'll mark this issue when I have the PR ready for review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants