fix: added transient connection default to identify service (libp2p#1573)

Author: maschad

packages/libp2p/src/identify/consts.ts

@@ -13,7 +13,8 @@ export const MAX_PUSH_INCOMING_STREAMS = 1
 export const MAX_PUSH_OUTGOING_STREAMS = 1
 export const MAX_OBSERVED_ADDRESSES = 10
 
-export const RUN_ON_TRANSIENT_CONNECTION = false
+export const RUN_ON_TRANSIENT_CONNECTION = true
+export const RUN_ON_CONNECTION_OPEN = true
 
 export const IDENTIFY_PROTOCOL_VERSION = '0.1.0'
 export const MULTICODEC_IDENTIFY_PROTOCOL_NAME = 'id'

packages/libp2p/src/identify/identify.ts

@@ -22,8 +22,7 @@ import {
   MAX_IDENTIFY_MESSAGE_SIZE,
   TIMEOUT,
   MAX_PUSH_OUTGOING_STREAMS,
-  MAX_OBSERVED_ADDRESSES,
-  RUN_ON_TRANSIENT_CONNECTION
+  MAX_OBSERVED_ADDRESSES
 } from './consts.js'
 import { Identify } from './pb/message.js'
 import type { IdentifyService, IdentifyServiceComponents, IdentifyServiceInit } from './index.js'
@@ -61,7 +60,7 @@ export class DefaultIdentifyService implements Startable, IdentifyService {
   private readonly maxIdentifyMessageSize: number
   private readonly maxObservedAddresses: number
   private readonly events: EventEmitter<Libp2pEvents>
-  private readonly runOnTransientConnection: boolean
+  private readonly runOnTransientConnection?: boolean
 
   constructor (components: IdentifyServiceComponents, init: IdentifyServiceInit) {
     this.started = false
@@ -81,7 +80,7 @@ export class DefaultIdentifyService implements Startable, IdentifyService {
     this.maxPushOutgoingStreams = init.maxPushOutgoingStreams ?? MAX_PUSH_OUTGOING_STREAMS
     this.maxIdentifyMessageSize = init.maxIdentifyMessageSize ?? MAX_IDENTIFY_MESSAGE_SIZE
     this.maxObservedAddresses = init.maxObservedAddresses ?? MAX_OBSERVED_ADDRESSES
-    this.runOnTransientConnection = init.runOnTransientConnection ?? RUN_ON_TRANSIENT_CONNECTION
+    this.runOnTransientConnection = init.runOnTransientConnection
 
     // Store self host metadata
     this.host = {

packages/libp2p/src/identify/index.ts

@@ -7,6 +7,8 @@ import {
   MULTICODEC_IDENTIFY,
   MULTICODEC_IDENTIFY_PUSH,
   PROTOCOL_PREFIX,
+  RUN_ON_CONNECTION_OPEN,
+  RUN_ON_TRANSIENT_CONNECTION,
   TIMEOUT
 } from './consts.js'
 import { DefaultIdentifyService } from './identify.js'
@@ -99,7 +101,8 @@ export function identifyService (init: IdentifyServiceInit = {}): (components: I
     maxIdentifyMessageSize: number().integer().min(0).default(MAX_IDENTIFY_MESSAGE_SIZE),
     maxInboundStreams: number().integer().min(0).default(MAX_INBOUND_STREAMS),
     maxOutboundStreams: number().integer().min(0).default(MAX_OUTBOUND_STREAMS),
-    runOnConnectionOpen: boolean().default(true)
+    runOnConnectionOpen: boolean().default(RUN_ON_CONNECTION_OPEN),
+    runOnTransientConnection: boolean().default(RUN_ON_TRANSIENT_CONNECTION)
   }).validateSync(init)
 
   return (components) => new DefaultIdentifyService(components, validatedConfig)