Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How the column prop is calculated? #6

Open
swyu0711 opened this issue Sep 28, 2018 · 1 comment
Open

How the column prop is calculated? #6

swyu0711 opened this issue Sep 28, 2018 · 1 comment

Comments

@swyu0711
Copy link

The column norm is squared in paper, while in code it is not squared as frobenious norm. It seems like a contradiction. I changed it to squared form as in the paper and found that accuracy decreased a lot.

@matenure
Copy link
Owner

Neither squaring nor nonsquaring guarantees variance reduction, as implied in the paper (see the paragraph above proposition 4). It’s up to empirical tuning to adopt the best sampling distribution. We did a quick check with cora and pubmed (using pubmed_Mix_sampleA.py) and found that the results between squaring and nonsquaring were quite comparable, with the latter slightly better. Thank you for spotting this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants