Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add debian-package icon for *.deb packages #2609

Closed
wants to merge 3 commits into from
Closed

Add debian-package icon for *.deb packages #2609

wants to merge 3 commits into from

Conversation

okineadev
Copy link
Member

Description

Added icon for *.deb packages

It may be necessary to remove the Debian logo because it is difficult to see, but it symbolizes Debian packages

Closes #2592

Contribution Guidelines

@github-actions github-actions bot added the icons PR with new icons label Sep 22, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 22, 2024 •
edited
Loading

Preview

Thank you for creating a pull request. This preview shows you how your icon will look on the different themes:

Generated preview

Check how your icon fits in a 16x16 grid with our Pixel Perfect Checker by following this link.

You can find more information on how to contribute in the contribution guidelines.

@PKief
Copy link
Member

PKief commented Sep 24, 2024

Preview

Thank you for creating a pull request. This preview shows you how your icon will look on the different themes:

Generated preview

Check how your icon fits in a 16x16 grid with our Pixel Perfect Checker by following this link.

You can find more information on how to contribute in the contribution guidelines.

In the small view of the file tree in VS Code the debian logo is very very hard to see if it's that small. So I have some concerns if this icon can be merged like that. By zooming in, the icons do look good sometimes, but we have to design them to be visible in a very small size.

okineadev
okineadev commented Oct 1, 2024
View reviewed changes
Copy link
Member Author

@okineadev okineadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you doing this?

@okineadev
Copy link
Member Author

Added in #2694

@okineadev okineadev closed this Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
icons PR with new icons
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Icon Request]: debian-package
2 participants
@okineadev @PKief