Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update_dns.sh unable to get zone_id #12

Open
nhandler opened this issue Jan 21, 2018 · 2 comments
Open

update_dns.sh unable to get zone_id #12

nhandler opened this issue Jan 21, 2018 · 2 comments
Assignees
@matfra

Comments

@nhandler
Copy link
Collaborator

It looks like this is probably due to quoting issues with the $PUBLIC_DOMAIN. Replacing the variable with a hardcoded value resolves the issue.
@matfra
Copy link
Owner

matfra commented Jan 23, 2018

I'll have a look at it.should i also add the option to create the entry?

@nhandler
Copy link
Collaborator Author

Maybe have the install script handle that (possibly by passing a flag to update_dns). For most people, they will only need to create the entry when they first set this up.

@matfra matfra self-assigned this Jan 25, 2018
@matfra matfra mentioned this issue Jan 25, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matfra matfra

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nhandler @matfra