Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to delete shared but deleted notes by another user #72

Open
elhananjair opened this issue Aug 8, 2021 · 9 comments
Open

Unable to delete shared but deleted notes by another user #72

elhananjair opened this issue Aug 8, 2021 · 9 comments

Comments

@elhananjair
Copy link

Hello there, I tried to delete some note from shared notes section, but it showing me note doesn't found error, this error caused because the note is already have been deleted by a person who shared it with me.

@damiankaczkowski
Copy link

damiankaczkowski commented Dec 1, 2021

+1
In my case person who shared is shown as unknown - "Shared by {user}". Probably due to the fact that the users are ldap users? When trying to delete such shared notes system gives you error message: "Could not delete note, not found".

@matiasdelellis
Copy link
Owner

Surely related to the other report, but i have to investigate this. 😞
Thanks for the report and sorry for the slow progress. 😞

@damiankaczkowski
Copy link

damiankaczkowski commented May 31, 2022

Hi @matiasdelellis . Any luv for this one so far : ] ?
In NC 23 this behaves a little bit differently. No error is shown in NC 23. I can now delete the note, but after page refresh it is back. Still no way to delete it permanently.

@matiasdelellis
Copy link
Owner

Hi @damiankaczkowski
Yo can test this tarball??? Just replace your nextcloud/apps/quicknotes folder with the content.

quicknotes.tar.gz

@matiasdelellis
Copy link
Owner

Ok.. With last commit also fix the original report.

quicknotes.tar.gz

NOTE: I'm not using NC23, so I can't guarantee it will work.. If test it for a few days and confirm that it works, I can publish it on NC23, otherwise just for NC24 🤔

@elhananjair
Copy link
Author

Can you push it to the nextcloud store? I will test it, actually am using NC24 since you did a test on that, that's good news. Thanks, @matiasdelellis quicknotes is a very useful app.

@damiankaczkowski
Copy link

damiankaczkowski commented Jun 1, 2022

@matiasdelellis It works now : ). Thank you! The only minor difference between non shared notes and shared notes is that when you delete standard note then all other notes are sorted and empty space after deleted note is automatically filled with other notes. When you delete shared note then the empty space after deleted note is not automatically filled with other notes. You have to manually refresh page for free space to get filled with other notes and to get them sorted again.

EDIT: @matiasdelellis: The above glitch occurs on NC23 and on NC24 too. But this is not a problem.

@damiankaczkowski
Copy link

damiankaczkowski commented Jun 2, 2022

@matiasdelellis I do not know if this is related to tar.gz update or just something else, but I just spot that filtering by colors and tags does not work. I click on a color or tag and nothing happens. It should display only selected color or tag IFAIR. Might be worth looking into this.

EDIT: @matiasdelellis: The above problem occurs only on NC23. NC24 works ok.

@damiankaczkowski
Copy link

Hi @matiasdelellis . Did you managed to confirm my findings or is it something on my end?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants