Fix one error regarding xml code inside html #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Hi @catarinaacsilva, sorry I miss this. I will test this out later today. Thanks |
Owner
|
Hi @catarinaacsilva thanks for the effort on adding feature. I'm working on a new version of the package and I will include fix into it. stay tune. |
|
@matiskay Just out of curiousity, is this sitll an active project? |
|
@matiskay Thanks for your work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear matiskay,
I am using your library to compare http and https Portuguese websites.
Some of the websites still use XML inside HTML.
I added one condition to your code to support lxml.html.HtmlProcessingInstruction (the XML tags were as the previously mentioned class).
Can you add this fix to your code?
Thanks,
Catarina