fix: add roll-out log to track config change history (#574)

aylei · web-flow · commit 3dbda1d8a253 · 2024-12-25T10:45:10.000+08:00
Signed-off-by: Aylei &lt;rayingecho@gmail.com&gt;
diff --git a/pkg/controllers/common/configmap.go b/pkg/controllers/common/configmap.go
@@ -27,6 +27,7 @@ import (
 	"github.com/matrixorigin/matrixone-operator/api/core/v1alpha1"
 	corev1 "k8s.io/api/core/v1"
 	apierrors "k8s.io/apimachinery/pkg/api/errors"
+	"k8s.io/klog"
 	"sigs.k8s.io/controller-runtime/pkg/client"
 )
 
@@ -93,6 +94,10 @@ func ensureConfigMap(kubeCli recon.KubeClient, desired *corev1.ConfigMap) (strin
 			if withDigest(key, v) && configInUse(key, podList.Items) {
 				// append item that is still in use
 				c.Data[key] = v
+			} else {
+				// log roll-out event to track configmap changes
+				klog.Infof("config key %s is not in use, will be deleted. configmap %s/%s, value: %s",
+					key, c.Namespace, c.Name, v)
 			}
 		}
 		err = kubeCli.Update(c)

Original file line number	Diff line number	Diff line change
`@@ -27,6 +27,7 @@ import (`
`27`	`27`	`"github.com/matrixorigin/matrixone-operator/api/core/v1alpha1"`
`28`	`28`	`corev1 "k8s.io/api/core/v1"`
`29`	`29`	`apierrors "k8s.io/apimachinery/pkg/api/errors"`
	`30`	`+ "k8s.io/klog"`
`30`	`31`	`"sigs.k8s.io/controller-runtime/pkg/client"`
`31`	`32`	`)`
`32`	`33`
`@@ -93,6 +94,10 @@ func ensureConfigMap(kubeCli recon.KubeClient, desired *corev1.ConfigMap) (strin`
`93`	`94`	`if withDigest(key, v) && configInUse(key, podList.Items) {`
`94`	`95`	`// append item that is still in use`
`95`	`96`	`c.Data[key] = v`
	`97`	`+ } else {`
	`98`	`+ // log roll-out event to track configmap changes`
	`99`	`+ klog.Infof("config key %s is not in use, will be deleted. configmap %s/%s, value: %s",`
	`100`	`+ key, c.Namespace, c.Name, v)`
`96`	`101`	`}`
`97`	`102`	`}`
`98`	`103`	`err = kubeCli.Update(c)`