From 10bfc512a03219119d4211ad7cfe6d4da4f9f692 Mon Sep 17 00:00:00 2001 From: danhobbs75 <59664466+danhobbs75@users.noreply.github.com> Date: Mon, 12 Dec 2022 13:08:16 +0000 Subject: [PATCH] fix: check if event is cancelable before calling preventDefault (#132) --- .gitignore | 1 + .../src/lib/resizable.directive.ts | 9 ++------- 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/.gitignore b/.gitignore index 6723602..600e6e3 100644 --- a/.gitignore +++ b/.gitignore @@ -45,3 +45,4 @@ projects/angular-resizable-element/package.json # System Files .DS_Store Thumbs.db +package-lock.json diff --git a/projects/angular-resizable-element/src/lib/resizable.directive.ts b/projects/angular-resizable-element/src/lib/resizable.directive.ts index 561b360..8876518 100644 --- a/projects/angular-resizable-element/src/lib/resizable.directive.ts +++ b/projects/angular-resizable-element/src/lib/resizable.directive.ts @@ -321,13 +321,8 @@ export class ResizableDirective implements OnInit, OnDestroy { this.mousemove ).pipe( tap(({ event }) => { - if (currentResize) { - try { - event.preventDefault(); - } catch (e) { - // just adding try-catch not to see errors in console if there is a passive listener for same event somewhere - // browser does nothing except of writing errors to console - } + if (currentResize && event.cancelable) { + event.preventDefault(); } }), share()