-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cores don't work anymore after changing display modes #354
Comments
What cores are you seeing this happen with? Can you also include the error message you're getting as well please? |
That helps a lot. I’ll look into it. Thank you! |
Hey @Ericchi! I had some time to look at this tonight. Unfortunately I'm not able to get it to error out like what you're seeing at all. If you're on the latest version of
If you set that to |
- Added a legacy solution and project file that targets .net7 for mattpannella#372 (will need to add this to the build system and still need to figure out how auto update will work with it) - General code clean up and consistency changes - Added a method to get all the exception messages when not in debug mode to get more information - Disabled some of the resharper warning - Removed the auto unzip logic from the archive service and added it to CoresService.Download to fix a problem with the image pack and palette download functionality - Created a temporary backup of the video.json file when applying display modes incase there's an error when writing the updated file back. This is for mattpannella#354 to see if it fixes the error that we can't reproduce.
- Added a legacy solution and project file that targets .net7 for #372 (will need to add this to the build system and still need to figure out how auto update will work with it) - General code clean up and consistency changes - Added a method to get all the exception messages when not in debug mode to get more information - Disabled some of the resharper warning - Removed the auto unzip logic from the archive service and added it to CoresService.Download to fix a problem with the image pack and palette download functionality - Created a temporary backup of the video.json file when applying display modes incase there's an error when writing the updated file back. This is for #354 to see if it fixes the error that we can't reproduce.
* Bugfixes and Code Cleanup - Added a legacy solution and project file that targets .net7 for #372 (will need to add this to the build system and still need to figure out how auto update will work with it) - General code clean up and consistency changes - Added a method to get all the exception messages when not in debug mode to get more information - Disabled some of the resharper warning - Removed the auto unzip logic from the archive service and added it to CoresService.Download to fix a problem with the image pack and palette download functionality - Created a temporary backup of the video.json file when applying display modes incase there's an error when writing the updated file back. This is for #354 to see if it fixes the error that we can't reproduce. * Added NET7_0 conditions for auto updating Added ifdef statements to stop the app from auto updating itself when it's in .NET7 mode. It does display a message to let the user know there is a new version though. * include csproj file name for now * dotnet 7 build work flow --------- Co-authored-by: Matt Pannella <[email protected]>
@Ericchi I put some changes in to help with this problem, but since I wasn't able to reproduce it I wasn't able to verify it worked. The changes include some logic to back up the original |
Describe the bug
Changing display modes for the cores completely breaks them.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
The display modes should be applied and the cores shouldn't be rendered unusable
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):
Contents of settings file
The text was updated successfully, but these errors were encountered: