Skip to content

License for the code #7

@danielealbano

Description

@danielealbano

Hi @mattsta!

I was having a look at your code, as I would be interested in using it to calculate the CRC64 to generate RDB files but I have noticed that the license on the files, i just 2 of them, refers to Redis but this repo is not under the Redis Labs organization or under the Redis project.

Specifically both crc16speed.c and crc64speed.c refer Redis in the license meanwhile crcspeed.c has a different license and the header files have no license.

Was it because of a copy & paste or is the code owner by Redis Labs?

Disclaimer:
I am implementing in my Key-Value store, it's called cachegrand ( https://github.com/danielealbano/cachegrand ) and as I am to make it Redis compatible I am adding the necessary bits and pieces to load and save RDB dumps.
Of course to have full compatibility I would like to have the CRC64 generation and check but after quite a while attempting to validate the RDB generated by my code with redis-check-rdb I discovered I was using a different polynomial (I am not an expert with CRC64) and after multiple attempts, even with pycrc, I wasn't able to make it work.

If it's a copy & paste I can make a PR to fix it, if not, thanks for the time spent reading my message :)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions