Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat the prompt line like a regular buffer #801

Open
lenormf opened this issue Sep 10, 2016 · 3 comments
Open

Treat the prompt line like a regular buffer #801

lenormf opened this issue Sep 10, 2016 · 3 comments

Comments

@lenormf
Copy link
Contributor

lenormf commented Sep 10, 2016

Hi,

Following the implementation of #800, I figured treating the prompt line just like any other buffer would allow applying different sets of bindings without having to hardcode them (emacs/vim bindings for instance).

The current implementation doesn't allow things like the following:

map global prompt <c-u> Ghd

Cheers.

@greduan
Copy link
Contributor

greduan commented Sep 23, 2016

I think this is a good idea, just to make sure that it's in insert mode by default and that escape closes the prompt, since this is now expected behaviour.

@danr
Copy link
Contributor

danr commented Oct 27, 2017

Additionally, this could open up for new completion possibilities in the prompt and possibly remove some duplicatied functionality. The current insertion mode completion could be used in this one-line-high prompt buffer, and the completion logic could be moved to kakrc scripts instead of -shell-completions and -shell-candidates etc.

@JJK96
Copy link
Contributor

JJK96 commented Dec 23, 2018

I am currently lookin into this one to see how much would need to be changed.

Currently I have that the InputHandler::Prompt class would be reimplemented.

Probably also something related to how it is displayed, but I cannot find where the Prompt is drawn/displayed. In ncurses_ui.cc I cannot find it. Maybe someone with more knowledge on the codebase can help me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants