Skip to content

Conversation

@tardate
Copy link
Contributor

@tardate tardate commented May 2, 2011

Hi Max, I've integrated a few contributions to the project, updated some of the docs and stepped the gem version to 0.1.1. All tests green at my end!

@tardate
Copy link
Contributor Author

tardate commented Feb 12, 2012

Hi Max, are you still maintaining this gem?

I just spent a bit of time today merging the changes from a bunch of people: James Coleman, Aaron Peckham, James Tippett, Tim Morgan", dakhota, Matthew Soldo.

Changes are all on this pull request now (which has also merged you own master, so it should be an easy fast-forward merge).

Tests are all green - hopefully that means I got everyone's changes in OK(!)

@maxlapshin
Copy link
Owner

Hi, can you, please, rebase your updates so, that I merge them?

@tardate
Copy link
Contributor Author

tardate commented Jul 20, 2012

Hi Max, sure I'll take another look now. Hopefully we can get the number of independent forks back to something a little more reasonable..

@tardate
Copy link
Contributor Author

tardate commented Jul 20, 2012

hmm, so I took a look at the latest master and its not a very clean merge. various people have been heading in different directions.

a few things that need to be resolved, and they require an opinion:

I'm not so sure about the changes made to use config/database.yml by default, and drop the ability of the tool to generate a config template for the user. Fine if you are running the tool from a cloned repo, but not consistent with using the tool as a gem.

There's also an unresolved issue of who's managing the gemspec. Current master is along the lines of manually managed, but jeweler is still in the project and Rakefile. Also, version in the gemspec is not consistent with the version that the gem reports.

Why have we removed all of the good info in the readme?

Max, you have any thoughts on which way to go on these issues?

@maxlapshin
Copy link
Owner

I think you can do anything you consider right =)

@tardate
Copy link
Contributor Author

tardate commented Jul 20, 2012

ok;-)

I'll get a fully resolved merge first, then look at some changes on top to clean up a bit

@paazmaya
Copy link
Contributor

Any updates on these changes?

@maxlapshin
Copy link
Owner

We can’t automatically merge this pull request.

@paazmaya
Copy link
Contributor

Ok, well let's see if I could sort these out...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants