Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable trivy image scan across projects #463

Closed
6 tasks done
SonnyBA opened this issue Oct 1, 2024 · 4 comments · Fixed by #465, open-zaak/open-zaak#1791, open-zaak/open-notificaties#194, maykinmedia/open-api-workflows#1 or #506
Assignees

Comments

@SonnyBA
Copy link
Contributor

SonnyBA commented Oct 1, 2024

Multiple CI builds are failing across projects because of issues with the trivy image scan step. This issue seems to be the cause but no official fix is released at the time of writing.

The image scan step should be re-enabled for projects which disabled it due to the above issue.

EDIT: trivy now uses the cache by default, which should solve the issue: aquasecurity/trivy-action#399

@SonnyBA SonnyBA converted this from a draft issue Oct 1, 2024
@stevenbal
Copy link
Collaborator

stevenbal added a commit to maykinmedia/open-klant that referenced this issue Oct 3, 2024
Coperh added a commit to open-zaak/open-notificaties that referenced this issue Oct 4, 2024
@Coperh
Copy link
Contributor

Coperh commented Oct 4, 2024

Disabled in Open-notificaties

Coperh added a commit to open-zaak/open-zaak that referenced this issue Oct 4, 2024
@Coperh
Copy link
Contributor

Coperh commented Oct 4, 2024

Disabled in Open Zaak (on release PR)

SonnyBA added a commit to maykinmedia/objecttypes-api that referenced this issue Oct 4, 2024
SonnyBA added a commit to maykinmedia/objecttypes-api that referenced this issue Oct 4, 2024
SonnyBA added a commit to maykinmedia/open-api-workflows that referenced this issue Oct 4, 2024
Coperh pushed a commit to maykinmedia/open-klant that referenced this issue Oct 4, 2024
SonnyBA added a commit that referenced this issue Oct 4, 2024
SonnyBA added a commit to open-zaak/open-zaak that referenced this issue Oct 4, 2024
SonnyBA added a commit that referenced this issue Oct 4, 2024
@github-project-automation github-project-automation bot moved this from Triage to Done in Data en API fundament Oct 4, 2024
SonnyBA added a commit to open-zaak/open-zaak that referenced this issue Oct 4, 2024
@SonnyBA SonnyBA moved this from Done to Todo in Data en API fundament Oct 11, 2024
@stevenbal stevenbal reopened this Oct 18, 2024
@github-project-automation github-project-automation bot moved this from Todo to In Progress in Data en API fundament Oct 18, 2024
@stevenbal
Copy link
Collaborator

This job has been fixed in Open Forms, so we could try the same for the registration components https://github.com/open-formulieren/open-forms/blob/master/.github/workflows/ci.yml#L414-L439

@stevenbal stevenbal moved this from In Progress to Todo in Data en API fundament Oct 18, 2024
@stevenbal stevenbal self-assigned this Oct 18, 2024
stevenbal added a commit to maykinmedia/open-api-workflows that referenced this issue Oct 18, 2024
stevenbal added a commit to open-zaak/open-notificaties that referenced this issue Oct 18, 2024
stevenbal added a commit to maykinmedia/open-api-workflows that referenced this issue Oct 18, 2024
@stevenbal stevenbal reopened this Dec 24, 2024
@github-project-automation github-project-automation bot moved this from Done to In Progress in Data en API fundament Dec 24, 2024
stevenbal added a commit that referenced this issue Dec 24, 2024
stevenbal added a commit to open-zaak/open-notificaties that referenced this issue Dec 24, 2024
stevenbal added a commit to open-zaak/open-zaak that referenced this issue Dec 24, 2024
stevenbal added a commit that referenced this issue Dec 24, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Data en API fundament Dec 24, 2024
@stevenbal stevenbal reopened this Dec 24, 2024
@github-project-automation github-project-automation bot moved this from Done to In Progress in Data en API fundament Dec 24, 2024
@stevenbal stevenbal moved this from In Progress to Implemented in Data en API fundament Dec 24, 2024
stevenbal added a commit to open-zaak/open-notificaties that referenced this issue Dec 24, 2024
@github-project-automation github-project-automation bot moved this from Implemented to Done in Data en API fundament Dec 24, 2024
@stevenbal stevenbal reopened this Dec 24, 2024
@github-project-automation github-project-automation bot moved this from Done to In Progress in Data en API fundament Dec 24, 2024
@stevenbal stevenbal moved this from In Progress to Implemented in Data en API fundament Dec 24, 2024
stevenbal added a commit to open-zaak/open-zaak that referenced this issue Jan 2, 2025
@github-project-automation github-project-automation bot moved this from Implemented to Done in Data en API fundament Jan 2, 2025
stevenbal added a commit to maykinmedia/objecttypes-api that referenced this issue Jan 2, 2025
…e-workflow

👷 [maykinmedia/objects-api#463] Remove unnecessary trivy cache workflow
SonnyBA added a commit that referenced this issue Jan 8, 2025
SonnyBA pushed a commit that referenced this issue Jan 8, 2025
SonnyBA pushed a commit that referenced this issue Jan 8, 2025
SonnyBA added a commit that referenced this issue Jan 8, 2025
SonnyBA pushed a commit that referenced this issue Jan 8, 2025
SonnyBA added a commit to maykinmedia/objecttypes-api that referenced this issue Jan 9, 2025
SonnyBA pushed a commit to maykinmedia/objecttypes-api that referenced this issue Jan 9, 2025
github-merge-queue bot pushed a commit to infonl/dimpact-zaakafhandelcomponent that referenced this issue Feb 19, 2025
…o v1.8.0 (#2737)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[docker.io/openzaak/open-notificaties](https://redirect.github.com/open-zaak/open-notificaties)
| minor | `1.7.1` -> `1.8.0` |

---

### Release Notes

<details>
<summary>open-zaak/open-notificaties
(docker.io/openzaak/open-notificaties)</summary>

###
[`v1.8.0`](https://redirect.github.com/open-zaak/open-notificaties/blob/HEAD/CHANGELOG.rst#180-2025-01-13)

[Compare
Source](https://redirect.github.com/open-zaak/open-notificaties/compare/1.7.1...1.8.0)

**New features**

-
\[[#&#8203;108](https://redirect.github.com/open-zaak/open-notificaties/issues/108)]
Admin action to check Abonnement callback status
-
\[[#&#8203;180](https://redirect.github.com/open-zaak/open-notificaties/issues/180)]
Provide an admin overview for notificatie responses
-
\[[#&#8203;207](https://redirect.github.com/open-zaak/open-notificaties/issues/207)]
Add experimental PUT and PATCH for Kanaal
-
\[[#&#8203;199](https://redirect.github.com/open-zaak/open-notificaties/issues/199)]
Add Admin OIDC Configuration step from django-setup-configuration
-
\[[#&#8203;204](https://redirect.github.com/open-zaak/open-notificaties/issues/204)]
Add SitesConfiguration step from django-setup-configuration
-
\[[#&#8203;200](https://redirect.github.com/open-zaak/open-notificaties/issues/200)]
Autorisaties-API configuration via django-setup-configuration
-
\[[#&#8203;202](https://redirect.github.com/open-zaak/open-notificaties/issues/202)]
Configuration Kanalen via django-setup-configuration
-
\[[#&#8203;202](https://redirect.github.com/open-zaak/open-notificaties/issues/202)]
Configuration Abonnementen via django-setup-configuration
-
\[[#&#8203;203](https://redirect.github.com/open-zaak/open-notificaties/issues/203)]
Configuration Notification settings via django-setup-configuration
-
\[[maykinmedia/open-api-framework#46](https://redirect.github.com/maykinmedia/open-api-framework/issues/46)]
Upgrade open-api-framework to 0.9.1

**Bugfixes and QOL**

-
\[[maykinmedia/open-api-framework#66](https://redirect.github.com/maykinmedia/open-api-framework/issues/66)]
Update zgw consumers to 0.36.0
-
\[[#&#8203;199](https://redirect.github.com/open-zaak/open-notificaties/issues/199)]
Upgrade mozilla-django-oidc-db to 0.21.1
-
\[[#&#8203;203](https://redirect.github.com/open-zaak/open-notificaties/issues/203)]
Upgrade notifications-api-common to 0.4.0
-
\[[#&#8203;204](https://redirect.github.com/open-zaak/open-notificaties/issues/204)]
Upgrade django-setup-configuration to 0.5.0
-
\[[#&#8203;200](https://redirect.github.com/open-zaak/open-notificaties/issues/200)]
Fix `CELERY_LOGLEVEL` not working
-
\[[#&#8203;200](https://redirect.github.com/open-zaak/open-notificaties/issues/200)]
Upgrade commonground-api-common to 2.2.0

.. warning::

Configuring external services is now done through the `Service` model.
This
replaces the `APICredential` model in the admin interface. A data
migration
was added to move to the `Service` model. It is advised to verify the
`Service`
instances in the admin to check that the data migration was ran as
expected.

.. warning::

``LOG_STDOUT`` configuration variable now defaults to ``True`` instead
of ``False``

.. warning::

    The previous setup configurations are no longer supported.
    Make sure to replace the old configurations with the new ones.

**Project maintenance**

-
\[[maykinmedia/objects-api#463](https://redirect.github.com/maykinmedia/objects-api/issues/463)]
Add trivy image scan
-
\[[maykinmedia/open-api-framework#92](https://redirect.github.com/maykinmedia/open-api-framework/issues/92)]
Fix docker latest tag publish
-
\[[maykinmedia/open-api-framework#13](https://redirect.github.com/maykinmedia/open-api-framework/issues/13)]
Consistent CI configuration across the different projects.

**Documentation**

-
\[[#&#8203;200](https://redirect.github.com/open-zaak/open-notificaties/issues/200)]
Update docs for setup configuration changes
-
\[[maykinmedia/objects-api#403](https://redirect.github.com/maykinmedia/objects-api/issues/403)]
Update delivery guarantee documentation

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/).
View the [repository job
log](https://developer.mend.io/github/infonl/dimpact-zaakafhandelcomponent).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xNzMuMSIsInVwZGF0ZWRJblZlciI6IjM5LjE3My4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment