Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add colorType documentation to CanvasRenderingContext2DSettings #38087

Open
ccameron-chromium opened this issue Feb 10, 2025 · 4 comments
Open
Labels
Content:WebAPI Web API docs waiting for implementations Waiting for feature to be implemented in browsers

Comments

@ccameron-chromium
Copy link

MDN URL

https://developer.mozilla.org/en-US/docs/Web/API/CanvasRenderingContext2D/getContextAttributes

What specific section or headline is this issue about?

Return value

What information was incorrect, unhelpful, or incomplete?

The new CanvasRenderingContext2DSettings attribute of colorType is absent.

This is a new property added in this PR.

What did you expect to see?

This affects the following pages.

For getContextAttributes under CanvasRenderingContext2D

  • Under the return value section
  • Add colorType for the color type.
  • Note that when issue 37727 is resolved, this will need to be added to the same section for OffscreenCanvasRenderingContext2D

For getContext on HTMLCanvasElement

  • In the 2d context attributes section
  • Add colorType to the list of parameters that affect the 2D context creation

For getContext for OffscreenCanvas

  • Do the same changes in the "2d context attributes" section as is done for the HTMLCanvasElement version of the function.

Do you have any supporting links, references, or citations?

PR for the change adding this feature:
whatwg/html#10951

Explainer for the feature:
https://github.com/ccameron-chromium/ColorWeb-CG/blob/canvas2d_float/canvas_float.md

Do you have anything more you want to share?

No response

@ccameron-chromium ccameron-chromium added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Feb 10, 2025
@github-actions github-actions bot added the Content:WebAPI Web API docs label Feb 10, 2025
@Josh-Cena
Copy link
Member

What's the implementation status?

@ccameron-chromium
Copy link
Author

ccameron-chromium commented Feb 10, 2025

Not shipping on any browser yet:

@Josh-Cena Josh-Cena added waiting for implementations Waiting for feature to be implemented in browsers and removed needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. labels Feb 10, 2025
@Josh-Cena Josh-Cena changed the title [HTML] Add colorType documentation to CanvasRenderingContext2DSettings Add colorType documentation to CanvasRenderingContext2DSettings Feb 10, 2025
@hamishwillee
Copy link
Collaborator

hamishwillee commented Feb 10, 2025

@ccameron-chromium I understand that updating MDN with these changes is part of the working group processes, which is excellent. Is there any way to hint in that process that the implementation status information you provided above be included in the post? We almost always have to ask for it (sometimes it is in the linked implementation PR)

EDIT. Actually, note Josh link below. Ignore. Thanks.

@Josh-Cena
Copy link
Member

@hamishwillee If you aren't aware: whatwg/meta#334

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs waiting for implementations Waiting for feature to be implemented in browsers
Projects
None yet
Development

No branches or pull requests

3 participants