From 5cca35ff27f6fa356215d86fa08a1ffcc493afa9 Mon Sep 17 00:00:00 2001 From: Ella Wu <602725+ewu63@users.noreply.github.com> Date: Tue, 9 Dec 2025 21:23:52 -0800 Subject: [PATCH 1/5] update maintainers file --- .github/CODEOWNERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 494cffb7..8e65f715 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -1 +1,3 @@ * @mdolab/pyoptsparse_maintainers +* @ewu63 +* @marcomangano From c2c77911d0f79acd88652fc38da490de839fbbe3 Mon Sep 17 00:00:00 2001 From: Ella Wu <602725+ewu63@users.noreply.github.com> Date: Tue, 9 Dec 2025 22:04:33 -0800 Subject: [PATCH 2/5] try bumping flang --- .github/environment.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/environment.yml b/.github/environment.yml index bd57cd36..07ce6355 100644 --- a/.github/environment.yml +++ b/.github/environment.yml @@ -9,7 +9,7 @@ dependencies: - pip - setuptools - build - - flang 5* + - flang>=18 - libpgmath # runtime - packaging From 61e495be9305baf547b1c79bc86c9a3a1fbb7f7a Mon Sep 17 00:00:00 2001 From: Ella Wu <602725+ewu63@users.noreply.github.com> Date: Tue, 9 Dec 2025 22:08:21 -0800 Subject: [PATCH 3/5] do not set env var FC --- .github/workflows/windows-build.yml | 3 --- 1 file changed, 3 deletions(-) diff --git a/.github/workflows/windows-build.yml b/.github/workflows/windows-build.yml index 54b3e109..ed0b70db 100644 --- a/.github/workflows/windows-build.yml +++ b/.github/workflows/windows-build.yml @@ -36,9 +36,6 @@ jobs: :: debug - list environment vars set - :: set fortran compiler, flang 5 activation doesn't seem to do it - set FC=flang.exe - python -m build -n -x . pip install --no-deps --no-index --find-links dist pyoptsparse From 3df59cacef5109781c0a3164a7beaf06be4b5006 Mon Sep 17 00:00:00 2001 From: Ella Wu <602725+ewu63@users.noreply.github.com> Date: Tue, 9 Dec 2025 22:15:29 -0800 Subject: [PATCH 4/5] remove unused windows.yaml file --- .github/windows.yaml | 40 ---------------------------------------- 1 file changed, 40 deletions(-) delete mode 100644 .github/windows.yaml diff --git a/.github/windows.yaml b/.github/windows.yaml deleted file mode 100644 index 5255487e..00000000 --- a/.github/windows.yaml +++ /dev/null @@ -1,40 +0,0 @@ -trigger: - - main - -pr: - - main - -pool: - vmImage: windows-latest - -jobs: - - job: Windows - steps: - - powershell: Write-Host "##vso[task.prependpath]$env:CONDA\Scripts" - displayName: Add conda to PATH - - - script: conda config --add channels conda-forge && conda config --set channel_priority strict - displayName: Set channel priority - - - script: conda create --yes --name pyos-build - displayName: Create environment - - - script: | - call activate pyos-build - call conda install -y mamba - call mamba env update --file .github/environment.yml - call mamba install -y libpgmath - displayName: Install mamba and update environment - - - script: | - set CC=cl - set FC=flang - set CC_LD=link - python -m build -n -x . - pip install --no-deps --no-index --find-links dist pyoptsparse - displayName: Build and install pyoptsparse - - - script: | - cd tests - testflo -n 1 . - displayName: Run tests From ee64f5ee0572b436a7d9bdfc439622f2fd512dc8 Mon Sep 17 00:00:00 2001 From: Ella Wu <602725+ewu63@users.noreply.github.com> Date: Tue, 9 Dec 2025 22:17:18 -0800 Subject: [PATCH 5/5] cleaned up docs --- doc/install.rst | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/doc/install.rst b/doc/install.rst index 29ff593d..e3347ade 100644 --- a/doc/install.rst +++ b/doc/install.rst @@ -5,7 +5,7 @@ Installation Instructions Conda ----- -Conda packages are available on ``conda-forge`` and can be installed via +Conda packages are available on conda-forge and can be installed via .. prompt:: bash @@ -165,7 +165,7 @@ This has the advantage that ``conda`` can be used to install all the necessary d Considering how finicky Windows can be with ABI compatibility among various compilers, this is the recommended approach. The guide will work on any platform, however. -The only build requirement for the build is a working ``conda`` installation as all compilers and dependencies are pulled from the ``conda-forge`` repos, with the exception of a Windows build, which requires Visual Studio 2017 C++ Build Tools. +The only build requirement for the build is a working ``conda`` installation as all compilers and dependencies are pulled from conda-forge. First, we need to create the ``conda`` environment. An ``environment.yml`` file is provided in the ``pyoptsparse`` repo: @@ -204,11 +204,6 @@ Finally, build the wheel and install it using pip: .. code-tab:: powershell Windows - # set specific compiler flags - set CC=cl - set FC=flang - set CC_LD=link - # build wheel python -m build -n -x .