Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android Bootcamp] Twitter Client Redux #2

Open
medha opened this issue Oct 30, 2013 · 1 comment
Open

[Android Bootcamp] Twitter Client Redux #2

medha opened this issue Oct 30, 2013 · 1 comment

Comments

@medha
Copy link
Owner

medha commented Oct 30, 2013

Hi Nathan (@nesquena),

Project 4 is ready for review.

I feel I have some redundant code in the fragments, as each of them have their own "load data from twitter api" method. Before I attempt any of the optional sections, I would first refactor my code to reduce some of the duplication.

Also, this project depends on the PullToRefreshListView library. I'm not sure whether it needs to be included as a jar within the Twitter project itself? At the moment, it needs to be added as a library in Eclipse.

Thanks!
Medha

@nesquena
Copy link

Medha, 👍 nice work overall. A few notes after checking out the code:

  • In the future, definitely consider additional polish for the UI by reviewing the cloning a screen tutorial and Q&A and the drawables guide.
  • Nice to see you used the FragmentTabListener to properly setup the tabs!
  • Nice use of tag to setup the ability to click the profile image and view a user's profile
  • For a future exercise, challenge yourself to move even more of the logic into the base Fragment class and out of the extension timeline fragments. For example, the scroll listener could be set in the base class and then the "onLoadMore" could call an abstract method which is defined separately in the extended class. This approach could be used to move almost all the logic into the base except for certain key abstract methods.

Here's a detailed Project 4 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you might be able to improve your submission.

This week (Week 5), we are going to cover the last major piece to the Android puzzle and that is using the hardware and SDK components such as the camera, photo gallery, location, maps, etc. After that, Week 6 we will be covering all the topics that separate an intermediate Android developer from a beginner that will act things you should start reviewing to continue your path to being a great Android developer.

Week 7 (Nov 11th), we are going to have a demo day to celebrate the progress you've all made with our next batch of Android students and multiple companies attending to see the group projects that you all have built. We are going to help however we can over the next 2 weeks to get the apps in shape and also have you all prepare a short slide presentation as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants