Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localization issue in admin dashboard UI #8124

Closed
yehiatarek63 opened this issue Jul 14, 2024 · 6 comments
Closed

Localization issue in admin dashboard UI #8124

yehiatarek63 opened this issue Jul 14, 2024 · 6 comments

Comments

@yehiatarek63
Copy link

Bug report

Bug Description

Some words are not localized meaning that they are always in english regardless of the language that I select.

Steps to reproduce the behavior

  1. Go to settings an switch to another language besides english
  2. The settings page along with other elements in the admin dashboard UI are still in english

Expected behavior

All text in the admin dashboard should be translated to the required language.

Screenshots

image
image

@srindom
Copy link
Collaborator

srindom commented Jul 17, 2024

Hi @yehiatarek63 - in v1 we don't have translation keys for settings titles and descriptions and we won't be able to find time to work on this. However, everything is translatable in v2.

I will close this for now, if someone is willing to work on adding translation keys for settings in v1 we'd be happy to accept a PR.

@srindom srindom closed this as completed Jul 17, 2024
@yehiatarek63
Copy link
Author

@srindom Thanks, I just wanted to ask, has multi-language been implemented yet in v2? I installed it and took a look but only English is available as of now and will there be RTL support for RTL languages?

@srindom
Copy link
Collaborator

srindom commented Jul 17, 2024

The admin application is ready for internationalization, but we only have an English file so far (https://github.com/medusajs/medusa/blob/develop/packages/admin-next/dashboard/public/locales/en-US/translation.json). New translations files will have to be added for other locales.

We haven't built RTL support into the new dashboard. I don't know much about the requirements for this. Is it simply a question of using dir="rtl" on the HTML tag and ensuring the styles take direction into account or is there more to it?

@yehiatarek63
Copy link
Author

  1. I can contribute to the arabic translation and make a PR
  2. To support RTL, we need to change dir="rtl".
  3. RTL version of the CSS is required
  4. RTL layout affects Arabic, Hebrew, Aramaic, Persian, Urdu and Kurdish
  5. Make sure that any SVGs like arrows are rotated in the RTL version

@srindom
Copy link
Collaborator

srindom commented Jul 17, 2024

We would be happy to accept an Arabic translation 🙏 I'd request that you wait a couple of weeks though since there's still plenty of active development on admin for v2. I will make a reminder to ping you when we are ready.

Regarding RTL, I don't think we will be able to prioritize this effort anytime soon. I believe we do get some help out of the box from Tailwind, however, it will be a big task to get it done across the admin application https://tailwindcss.com/blog/tailwindcss-v3#rtl-and-ltr-modifiers. If anyone feels inclined to PR it we would be happy to help make it land.

@MEClouds
Copy link

MEClouds commented Jul 17, 2024

Hi there,

I am already working on adding RTL support and fixing some issues. I will make pull requests after finishing it. Right now, I am working on:

  • Adding RTL support
  • Fixing the UI to work correctly in RTL
  • Adding the missing translations

After I finish these tasks, I will make the pull requests.

  • RTL Support (done)
  • Fixing UI in RTL (done)
  • Adding missing translations(in progress)

image

@srindom
#8245

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants