Skip to content

Improve error message when adding a wrong localhost URL #1028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
curquiza opened this issue Jul 18, 2024 · 5 comments · May be fixed by #1096
Open

Improve error message when adding a wrong localhost URL #1028

curquiza opened this issue Jul 18, 2024 · 5 comments · May be fixed by #1096
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@curquiza
Copy link
Member

Following this issue: meilisearch/meilisearch#4697

Improve the error message when an URL that lacks the protocol/scheme part is provided to Meilisearch

Currently we return: "Failed to connect to Meilisearch: No connection adapters were found for 'localhost:7700/version"

We want to be more explicit that the protocol/scheme is missing
@curquiza curquiza added enhancement New feature or request good first issue Good for newcomers labels Jul 18, 2024
@curquiza curquiza mentioned this issue Jul 18, 2024
Closed
@flevi29
Copy link

flevi29 commented Sep 9, 2024

Isn't this a meilisearch-python issue? It should be moved there, if that's the case.

@curquiza
Copy link
Member Author

@flevi29, hum, i'm not sure, why do you say this?

@flevi29
Copy link

flevi29 commented Sep 16, 2024

Just going after the error message, it looks like a python thing.

@curquiza
Copy link
Member Author

Discussed with @ManyTheFish and this is not only a problem to fix on Python's side

In the error message, we may want to add an additional information saying that it’s related to --http-addr or MEILI_HTTP_ADDR

@irevoire
Copy link
Member

Yes, and since the SDK couldn’t reach Meilisearch, it definitely cannot be a Meilisearch error message

@waks11 waks11 mentioned this issue Oct 3, 2024
Closed
@irevoire irevoire transferred this issue from meilisearch/meilisearch Oct 8, 2024
ellnix added a commit to ellnix/meilisearch-python that referenced this issue Apr 9, 2025
@ellnix
Give helpful error message when missing protocol
5ac8136 
Fixes meilisearch#1028
@ellnix ellnix linked a pull request Apr 9, 2025 that will close this issue
Open
ellnix added a commit to ellnix/meilisearch-ruby that referenced this issue Apr 12, 2025
@ellnix
Throw useful error message when URL missing scheme
4db33a3 
Inspired by meilisearch/meilisearch-python#1028
ellnix added a commit to ellnix/meilisearch-ruby that referenced this issue Apr 12, 2025
@ellnix
Throw useful error message when URL missing scheme
745a259 
Inspired by meilisearch/meilisearch-python#1028
@ellnix ellnix mentioned this issue Apr 12, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
3 participants
@irevoire @curquiza @flevi29