Skip to content

Commit 6740b8f

Browse files
committed
Implement CR comments
1 parent 981f02f commit 6740b8f

File tree

3 files changed

+4
-7
lines changed

3 files changed

+4
-7
lines changed

lib/ex_hls/client.ex

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ defmodule ExHLS.Client do
3535
media_playlist: nil,
3636
media_base_url: nil,
3737
multivariant_playlist: multivariant_playlist,
38-
multivariant_playlist_string: request_body,
38+
root_playlist_string: request_body,
3939
base_url: Path.dirname(url),
4040
video_chunks: [],
4141
demuxing_engine_impl: nil,
@@ -70,7 +70,7 @@ defmodule ExHLS.Client do
7070

7171
defp read_media_playlist_without_variant(%{media_playlist: nil} = client) do
7272
deserialized_media_playlist =
73-
client.multivariant_playlist_string
73+
client.root_playlist_string
7474
|> ExM3U8.deserialize_media_playlist!([])
7575

7676
%{

mix.exs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,7 @@ defmodule ExHLS.Mixfile do
3737

3838
defp deps do
3939
[
40-
# {:ex_m3u8, "~> 0.15.2"},
41-
{:ex_m3u8, path: "../ex_m3u8"},
40+
{:ex_m3u8, "~> 0.15.3"},
4241
{:req, "~> 0.5.10"},
4342
{:qex, "~> 0.5.1"},
4443
{:membrane_mp4_plugin, "~> 0.35.3"},

test/client_test.exs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ defmodule Client.Test do
22
use ExUnit.Case, async: true
33

44
alias ExHLS.Client
5-
65
alias Membrane.{AAC, H264, RemoteStream}
76

87
@fixtures "https://raw.githubusercontent.com/membraneframework-labs/ex_hls/refs/heads/support-one-media-type/test/fixtures/"
@@ -122,8 +121,7 @@ defmodule Client.Test do
122121
assert video_chunk.metadata == %{discontinuity: false, is_aligned: false}
123122
end
124123

125-
@tag :d
126-
test "(fMP4) stream with only audio" do
124+
test "(fMP4) stream with only video" do
127125
client = Client.new(@fmp4_only_video_url)
128126

129127
assert Client.get_variants(client) == %{}

0 commit comments

Comments
 (0)