Skip to content

Commit 951c1b8

Browse files
Andries SmitAndries Smit
authored andcommitted
Ignore LVC for non supported list views
1 parent 0e57467 commit 951c1b8

File tree

5 files changed

+24
-40
lines changed

5 files changed

+24
-40
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,10 @@
22
[![Dependency Status](https://david-dm.org/mendixlabs/list-view-controls.svg)](https://david-dm.org/mendixlabs/list-view-controls)
33
[![Dev Dependency Status](https://david-dm.org/mendixlabs/list-view-controls.svg#info=devDependencies)](https://david-dm.org/mendixlabs/list-view-controls#info=devDependencies)
44
[![codecov](https://codecov.io/gh/mendixlabs/list-view-controls/branch/master/graph/badge.svg)](https://codecov.io/gh/mendixlabs/list-view-controls)
5-
![badge](https://img.shields.io/badge/mendix-7.7.1-green.svg)
5+
![badge](https://img.shields.io/badge/mendix-7.20.0-green.svg)
66

77
# List view controls
8-
Enable users to filter or search a list view.
8+
Enable users to filter or search a list view with a data sources Database or XPath
99

1010
## Available widgets
1111
* `Check box filter`: Filters a list view with various constraints when checked or unchecked

package-lock.json

Lines changed: 13 additions & 36 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,12 @@
11
{
22
"name": "list-view-controls",
33
"widgetName": "ListViewControls",
4-
"version": "1.3.1",
4+
"version": "1.3.2",
55
"description": "Search and filter Mendix list views",
66
"copyright": "Mendix BV",
77
"scripts": {
88
"start": "webpack-dev-server --hot --open",
9+
"dev": "grunt",
910
"typeCheck": "tsc --noEmit",
1011
"pretest": "npm run typeCheck && npm run lint && npm run build",
1112
"test": "npm run test:unit && npm run test:conditional",

src/Shared/ListViewPrototype.ts

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,13 @@ import { DataSourceHelperListView, Paging } from "./DataSourceHelper/DataSourceH
8585
}
8686

8787
function listviewInstanceCompatible(listview: DataSourceHelperListView) {
88+
const ignore = !!(listview
89+
&& !(listview.datasource.type === "database" || listview.datasource.type === "xpath"));
90+
if (ignore) {
91+
return false;
92+
}
8893
const compatible = !!(listview
94+
&& (listview.datasource.type === "database" || listview.datasource.type === "xpath")
8995
&& listview._datasource
9096
&& listview._datasource.reload
9197
&& listview._datasource.setOffset

src/package.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?xml version="1.0" encoding="utf-8" ?>
22
<package xmlns="http://www.mendix.com/package/1.0/">
3-
<clientModule name="ListViewControls" version="1.3.1" xmlns="http://www.mendix.com/clientModule/1.0/">
3+
<clientModule name="ListViewControls" version="1.3.2" xmlns="http://www.mendix.com/clientModule/1.0/">
44
<widgetFiles>
55
<widgetFile path="CheckBoxFilter/CheckBoxFilter.xml"/>
66
<widgetFile path="DropDownFilter/DropDownFilter.xml"/>

0 commit comments

Comments
 (0)