Review improve e2e

Author: Andries Smit

tests/e2e/Pagination/Pagination.spec.ts

@@ -1,5 +1,6 @@
 import page from "./pages/home.page";
 import pagesize from "./pages/pageSize.page";
+import paginationCustom from "./pages/paginationCustom.page";
 
 const testValueOne = "Color 1";
 const testValueFive = "Color 5";
@@ -78,13 +79,13 @@ describe("Pagination", () => {
 
     it("when custom button is clicked list view should show item on the custom page ", () => {
 
-        page.openCustom();
+        paginationCustom.open();
 
-        page.customButtonTwo.waitForDisplayed(120000);
-        page.customButtonTwo.click();
-        page.listView4ThirdItem.waitForDisplayed();
+        paginationCustom.customButtonTwo.waitForDisplayed(120000);
+        paginationCustom.customButtonTwo.click();
+        paginationCustom.listView4ThirdItem.waitForDisplayed();
 
-        const thirdItemValue = page.listView4ThirdItem.getHTML();
+        const thirdItemValue = paginationCustom.listView4ThirdItem.getHTML();
         expect(thirdItemValue).toContain("Color P 3");
     });
 

tests/e2e/Pagination/pages/paginationCustom.page.ts

@@ -0,0 +1,35 @@
+class PaginationCustom {
+    public get paginationOne() { return $(".mx-name-pagination9"); }
+
+    public get listViewOne() { return $(".mx-name-listView1"); }
+
+    public get nextButton() { return $(".mx-name-pagination9 > div > button.btn.mx-button.mx-name-paging-next"); }
+
+    public get firstButton() { return $(".mx-name-pagination9 > div > button.btn.mx-button.mx-name-paging-first"); }
+
+    public get previousButton() { return $(".mx-name-pagination9 > div > button.btn.mx-button.mx-name-paging-previous"); }
+
+    public get customButtonTwo() { return $("#mxui_widget_ReactCustomWidgetWrapper_0 > div > ul > li:nth-child(2)"); }
+
+    public get lastButton() { return $(".mx-name-pagination9 > div > button.btn.mx-button.mx-name-paging-last"); }
+
+    public get listViewFirstItem() { return $(".mx-name-listView1 > ul > li.mx-listview-item.mx-name-index-0 > div > div > span"); }
+
+    public get listViewThirdItem() { return $(".mx-name-listView1 > ul > li.mx-listview-item.mx-name-index-2 > div > div > span"); }
+
+    public get listView4ThirdItem() { return $("ul > li.mx-listview-item.mx-name-index-2"); }
+
+    public get listViewFifthItem() { return $(".mx-name-listView1 > ul > li.mx-listview-item.mx-name-index-4 > div > div > span"); }
+
+    public get listViewSeventhItem() { return $(".mx-name-listView1 > ul > li.mx-listview-item.mx-name-index-6 > div > div > span"); }
+
+    public get listViewNinethItem() { return $(".mx-name-listView1 > ul > li.mx-listview-item.mx-name-index-8 > div > div > span"); }
+
+    public get listViewLastItem() { return $(".mx-name-listView1 > ul > li.mx-listview-item.mx-name-index-18 > div > div > span"); }
+
+    public open(): void {
+        browser.url("/p/pagination-custom");
+    }
+}
+const page = new PaginationCustom();
+export default page;

tests/e2e/TextSearch/TextBoxSearch.spec.ts

@@ -6,16 +6,26 @@ describe("Text box search", () => {
     it("when query is entered in the search input the list view should be filtered", () => {
         page.open();
         page.searchInput.waitForDisplayed();
+
         expect(page.listViewListItems.length).toBe(5);
         page.searchInput.click();
         page.searchInput.setValue(testValue);
-        browser.pause(1000);
+
+        browser.waitUntil(() => {
+            return page.listViewListItems.length === 1;
+        }, 5000, "wait for single item");
         expect(page.listViewListItems.length).toBe(1);
     });
 
     it("when query is entered in the search input and clear button clicked the list view should be filtered with new query", () => {
         page.open();
         page.searchInput.waitForDisplayed();
+
+        browser.waitUntil(() => {
+            return page.listViewListItems.length === 5;
+        }, 5000, "wait for initial items");
+        expect(page.listViewListItems.length).toBe(5);
+
         page.searchInput.click();
         page.searchInput.setValue(testValue);
 
@@ -24,18 +34,11 @@ describe("Text box search", () => {
         }, 5000, "wait for single item");
         expect(page.listViewListItems.length).toBe(1);
 
-        page.searchButton.click();
+        page.searchClearButton.click();
 
         browser.waitUntil(() => {
             return page.listViewListItems.length === 5;
         }, 5000, "wait for clear search");
         expect(page.listViewListItems.length).toBe(5);
-
-        page.searchInput.setValue("en");
-
-        browser.waitUntil(() => {
-            return page.listViewListItems.length === 4;
-        }, 5000, "wait for search items");
-        expect(page.listViewListItems.length).toBe(4);
     });
 });

tests/e2e/TextSearch/pages/home.page.ts

@@ -1,6 +1,6 @@
 class HomePage {
     public get searchInput() { return $(".mx-name-text_boxSearch1 input"); }
-    public get searchButton() { return $(".mx-name-text_boxSearch1 button"); }
+    public get searchClearButton() { return $(".mx-name-text_boxSearch1 button"); }
     public get listViewList() { return $(".mx-name-listView3 .mx-listview-list"); }
     public get listViewListItems() { return $$(".mx-name-listView3 .mx-listview-item"); }
     public open(): void {