Skip to content

Commit 4229d01

Browse files
refactor: remove dead boolean cell type and fix test name
Remove "b" from ExcelCell.t union and boolean from ExcelCell.v since excelBoolean now returns string cells. Fix misleading test name for undefined dynamicText case. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent 43247fc commit 4229d01

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

packages/pluggableWidgets/datagrid-web/src/features/data-export/__tests__/cell-readers.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ describe("cell-readers", () => {
111111
expect(cell.v).toBe("formatted text");
112112
});
113113

114-
it("exports n/a when unavailable", () => {
114+
it("returns empty cell when dynamicText is undefined", () => {
115115
const col = column("Label", c => {
116116
c.showContentAs = "dynamicText";
117117
c.dynamicText = undefined;

packages/pluggableWidgets/datagrid-web/src/features/data-export/cell-readers.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,10 @@ import { ColumnsType, ShowContentAsEnum } from "../../../typings/DatagridProps";
44

55
/** Represents a single Excel cell (SheetJS compatible) */
66
export interface ExcelCell {
7-
/** Cell type: 's' = string, 'n' = number, 'b' = boolean, 'd' = date */
8-
t: "s" | "n" | "b" | "d";
7+
/** Cell type: 's' = string, 'n' = number, 'd' = date */
8+
t: "s" | "n" | "d";
99
/** Underlying value */
10-
v: string | number | boolean | Date;
10+
v: string | number | Date;
1111
/** Optional Excel number/date format, e.g. "yyyy-mm-dd" or "$0.00" */
1212
z?: string;
1313
/** Optional pre-formatted display text */

0 commit comments

Comments
 (0)