Skip to content

Commit 6c9f4b5

Browse files
committed
build: fix build command in few widgets
1 parent b791a42 commit 6c9f4b5

File tree

9 files changed

+15
-24
lines changed

9 files changed

+15
-24
lines changed

.npmrc

+1
Original file line numberDiff line numberDiff line change
@@ -31,3 +31,4 @@ public-hoist-pattern[]=*cypress*
3131
public-hoist-pattern[]=*shelljs*
3232
public-hoist-pattern[]=*rollup*
3333
public-hoist-pattern[]=@types/node
34+
public-hoist-pattern[]=@types/big.js

package.json

+1
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@
3535
},
3636
"overrides": {
3737
"@types/react": "^18.2.9",
38+
"@types/big.js": "^6.1.6",
3839
"d3-color@<3.1.0": ">=3.1.0",
3940
"loader-utils@<1.4.1": ">=1.4.1",
4041
"loader-utils@>=3.0.0 <3.2.1": ">=3.2.1",

packages/pluggableWidgets/datagrid-number-filter-web/package.json

-1
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@
4040
},
4141
"dependencies": {
4242
"@mendix/pluggable-widgets-commons": "workspace:*",
43-
"big.js": "^6.2.1",
4443
"classnames": "^2.3.2"
4544
},
4645
"devDependencies": {

packages/pluggableWidgets/google-tag-web/src/GoogleTag.tsx

+4-6
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ function GoogleTagBasicPageView(props: GoogleTagContainerProps): ReactElement |
2323
if (!needsExecution.current) {
2424
return;
2525
}
26-
if (props.targetId && props.targetId.status !== "available") {
26+
if (props.targetId?.status !== "available") {
2727
return;
2828
}
2929
if (!areParametersReady(props.parameters)) {
@@ -37,7 +37,7 @@ function GoogleTagBasicPageView(props: GoogleTagContainerProps): ReactElement |
3737
{
3838
send_page_view: false
3939
},
40-
props.targetId && props.targetId.value
40+
props.targetId.value
4141
);
4242

4343
// execute event page_view
@@ -76,9 +76,7 @@ function GoogleTagAdvancedMode(props: GoogleTagContainerProps): ReactElement | n
7676
if (!needsExecution.current) {
7777
return;
7878
}
79-
if (props.targetId && props.targetId.status !== "available") {
80-
return;
81-
}
79+
8280
if (!areParametersReady(props.parameters)) {
8381
return;
8482
}
@@ -88,7 +86,7 @@ function GoogleTagAdvancedMode(props: GoogleTagContainerProps): ReactElement | n
8886
props.command,
8987
props.eventName,
9088
prepareParameters(props.parameters),
91-
props.targetId && props.targetId.value
89+
props.targetId?.value ?? ""
9290
);
9391

9492
needsExecution.current = false;

packages/pluggableWidgets/google-tag-web/src/utils.ts

+4
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,10 @@ function prepareValue(p: ParametersType): string | boolean {
1515
return getPredefinedValue(p.predefinedValue);
1616
}
1717

18+
if (!p.customValue || !p.customValue?.value) {
19+
throw new Error("no custom value");
20+
}
21+
1822
const value = p.customValue.value;
1923

2024
return value === "false" ? false : value === "true" ? true : replaceFullPathToken(value);

packages/pluggableWidgets/rating-web/src/StarRating.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { createElement, ReactElement, useCallback } from "react";
22
import { Rating as RatingComponent } from "./components/Rating";
33
import { ValueStatus } from "mendix";
44
import { executeAction, isAvailable } from "@mendix/pluggable-widgets-commons";
5-
import { Big } from "big.js";
5+
import Big from "big.js";
66
import { StarRatingContainerProps } from "../typings/StarRatingProps";
77
import { Icon } from "./components/Icon";
88

packages/pluggableWidgets/selection-helper-web/src/SelectionHelper.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ export function SelectionHelper(props: SelectionHelperContainerProps): ReactElem
2929
{selection.status === "all" && props.customAllSelected}
3030
{selection.status === "some" && props.customSomeSelected}
3131
{selection.status === "none" && props.customNoneSelected}
32-
{props.checkboxCaption.value ?? ""}
32+
{props.checkboxCaption?.value ?? ""}
3333
</SelectionHelperComponent>
3434
);
3535
}

packages/shared/pluggable-utils/package.json

-3
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,5 @@
3030
"@mendix/eslint-config-web-widgets": "workspace:*",
3131
"@mendix/prettier-config-web-widgets": "workspace:*",
3232
"@mendix/tsconfig-web-widgets": "workspace:*"
33-
},
34-
"dependencies": {
35-
"big.js": "^6.0.2"
3633
}
3734
}

pnpm-lock.yaml

+3-12
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)