chore: remove dead code on release (#2025)

Author: r0b1n

automation/utils/bin/rui-include-oss-in-artifact.ts

@@ -54,7 +54,7 @@ async function main(): Promise<void> {
     if (!htmlAsset) {
         console.log(chalk.yellow("⚠️  No HTML file found in release - nothing to include"));
         console.log(chalk.gray("   Skipping MPK modification\n"));
-        process.exit(0);
+        return;
     }
 
     console.log(chalk.green(`✅ Found HTML: ${htmlAsset.name}`));
@@ -80,8 +80,8 @@ async function main(): Promise<void> {
         await includeReadmeOssIntoMpk(htmlPath, mpkPath);
         console.log(chalk.green("✅ Merge completed"));
 
-        // Step 5: Remove old assets, upload patched MPK
-        console.log(chalk.blue("\n🔄 Replacing MPK asset in release..."));
+        // Step 5: Remove old assets and upload patched MPK
+        console.log(chalk.blue("\n🔄 Replacing assets in release..."));
 
         console.log(chalk.gray(`   → Deleting old MPK asset...`));
         await gh.deleteReleaseAsset(mpkAsset.id);
@@ -93,16 +93,23 @@ async function main(): Promise<void> {
         const newAsset = await gh.uploadReleaseAsset(releaseId, mpkPath, mpkAsset.name);
 
         console.log(chalk.green(`✅ Successfully replaced MPK asset (ID: ${newAsset.id})`));
-        console.log(chalk.bold.green(`\n🎉 Process completed successfully!\n`));
+
+        // Summary
+        console.log(chalk.bold.green(`\n🎉 Process completed successfully!`));
+        console.log(chalk.gray(`   Release: ${releaseTag}`));
+        console.log(chalk.gray(`   MPK: ${mpkAsset.name} (with embedded READMEOSS)\n`));
     } finally {
-        // Step 8: Cleanup temp files
+        // Cleanup temp files
         console.log(chalk.gray("🧹 Cleaning up temporary files..."));
         await rm("-rf", tmpFolder);
     }
 }
 
-main().catch(error => {
-    console.error(chalk.red(`\n❌ Error: ${error.message}\n`));
-    console.error(error);
+main().catch((error: unknown) => {
+    const message = error instanceof Error ? error.message : String(error);
+    console.error(chalk.red(`\n❌ Error: ${message}\n`));
+    if (error instanceof Error && error.stack) {
+        console.error(chalk.gray(error.stack));
+    }
     process.exit(1);
 });

automation/utils/src/oss-clearance.ts

@@ -5,17 +5,6 @@ import { mkdtemp, stat } from "node:fs/promises";
 import { chmod, cp, exec, mkdir, mv, rm, unzip, zip } from "./shell";
 import chalk from "chalk";
 
-export function findOssReadme(packageRoot: string, widgetName: string, version: string): string | undefined {
-    const readmeossPattern = `**/*${widgetName}__${version}__READMEOSS_*.html`;
-
-    console.info(`Looking for READMEOSS file matching pattern: ${readmeossPattern}`);
-
-    // Use glob to find files matching the pattern in package root
-    const matchingFiles = globSync(readmeossPattern, { cwd: packageRoot, absolute: true, ignore: "**/dist/**" });
-
-    return matchingFiles[0];
-}
-
 export function findAllReadmeOssLocally(): string[] {
     const readmeossPattern = join("**", `*__*__READMEOSS_*.html`);
     const path1 = join(homedir(), "Downloads");
@@ -90,5 +79,7 @@ export async function includeReadmeOssIntoMpk(readmeOssPath: string, mpkPath: st
 
     // zip it back
     await zip(unzipTarget, mpkPath);
+
+    // remove tmp folder
     rm("-rf", unzipTarget);
 }

automation/utils/src/steps.ts

@@ -14,7 +14,6 @@ import { ModuleInfo, PackageInfo, WidgetInfo } from "./package-info";
 import { addFilesToPackageXml, PackageType } from "./package-xml";
 import { chmod, cp, ensureFileExists, exec, find, mkdir, popd, pushd, rm, unzip, zip } from "./shell";
 import chalk from "chalk";
-import { findOssReadme } from "./oss-clearance";
 
 type Step<Info, Config> = (params: { info: Info; config: Config }) => Promise<void>;
 
@@ -197,44 +196,6 @@ export async function addWidgetsToMpk({ config }: ModuleStepParams): Promise<voi
     rm("-rf", target);
 }
 
-export async function addREADMEOSSToMpk({ config, info }: ModuleStepParams): Promise<void> {
-    logStep("Add READMEOSS to mpk");
-
-    // Check that READMEOSS file exists in package root and find it by name pattern
-    const packageRoot = config.paths.package;
-    const widgetName = info.mxpackage.name;
-    const version = info.version.format();
-
-    // We'll search for files matching the name and version, ignoring timestamp
-    const readmeossFile = findOssReadme(packageRoot, widgetName, version);
-
-    if (!readmeossFile) {
-        console.warn(`⚠️  READMEOSS file not found for ${widgetName} version ${version}.`);
-        console.warn(`   Skipping READMEOSS addition to mpk.`);
-        return;
-    }
-
-    console.info(`Found READMEOSS file: ${parse(readmeossFile).base}`);
-
-    const mpk = config.output.files.modulePackage;
-    const mpkEntry = parse(mpk);
-    const target = join(mpkEntry.dir, "tmp");
-
-    rm("-rf", target);
-
-    console.info("Unzip module mpk");
-    await unzip(mpk, target);
-    chmod("-R", "a+rw", target);
-
-    console.info(`Add READMEOSS file to ${mpkEntry.base}`);
-    // Copy the READMEOSS file to the target directory
-    cp(readmeossFile, target);
-
-    console.info("Create module zip archive");
-    await zip(target, mpk);
-    rm("-rf", target);
-}
-
 export async function moveModuleToDist({ info, config }: ModuleStepParams): Promise<void> {
     logStep("Move module to dist");
 
@@ -244,15 +205,6 @@ export async function moveModuleToDist({ info, config }: ModuleStepParams): Prom
     mkdir("-p", join(paths.dist, info.version.format()));
     // Can't use mv because of https://github.com/shelljs/shelljs/issues/878
     cp(output.files.modulePackage, output.files.mpk);
-
-    // Prepare OSS clearance folder structure
-    const ossClearanceFolder = join(paths.dist, "SBOM_GENERATOR", `${info.mxpackage.name} ${info.version.format()}`);
-    mkdir("-p", ossClearanceFolder);
-
-    // Copy module package to OSS clearance folder
-    console.info(`Copying module package to OSS clearance folder: ${ossClearanceFolder}`);
-    cp(output.files.modulePackage, join(ossClearanceFolder, `${info.mxpackage.name} ${info.version.format()}.mpk`));
-
     rm(output.files.modulePackage);
 }
 

packages/modules/calendar/scripts/release.ts

@@ -1,7 +1,6 @@
 #!/usr/bin/env ts-node-script
 
 import {
-    addREADMEOSSToMpk,
     addWidgetsToMpk,
     cloneTestProject,
     copyModuleLicense,
@@ -24,7 +23,6 @@ async function main(): Promise<void> {
             copyWidgetsToProject,
             createModuleMpk,
             addWidgetsToMpk,
-            addREADMEOSSToMpk,
             moveModuleToDist
         ]
     });

packages/modules/data-widgets/scripts/release.ts

@@ -1,7 +1,6 @@
 #!/usr/bin/env ts-node-script
 
 import {
-    addREADMEOSSToMpk,
     addWidgetsToMpk,
     cloneTestProject,
     copyActionsFiles,
@@ -31,7 +30,6 @@ async function main(): Promise<void> {
             copyModuleLicense,
             createModuleMpk,
             addWidgetsToMpk,
-            addREADMEOSSToMpk,
             moveModuleToDist
         ]
     });

packages/modules/file-uploader/scripts/release.ts

@@ -1,7 +1,6 @@
 #!/usr/bin/env ts-node-script
 
 import {
-    addREADMEOSSToMpk,
     addWidgetsToMpk,
     cloneTestProject,
     copyModuleLicense,
@@ -24,7 +23,6 @@ async function main(): Promise<void> {
             copyWidgetsToProject,
             createModuleMpk,
             addWidgetsToMpk,
-            addREADMEOSSToMpk,
             moveModuleToDist
         ]
     });

packages/modules/google-tag/scripts/release.ts

@@ -1,7 +1,6 @@
 #!/usr/bin/env ts-node-script
 
 import {
-    addREADMEOSSToMpk,
     addWidgetsToMpk,
     cloneTestProject,
     copyActionsFiles,
@@ -24,7 +23,6 @@ async function main(): Promise<void> {
             writeVersionAndLicenseToJSActions,
             createModuleMpk,
             addWidgetsToMpk,
-            addREADMEOSSToMpk,
             moveModuleToDist
         ]
     });

packages/modules/web-actions/scripts/release.ts

@@ -1,5 +1,4 @@
 import {
-    addREADMEOSSToMpk,
     cloneTestProject,
     copyActionsFiles,
     createModuleMpk,
@@ -30,7 +29,6 @@ async function main(): Promise<void> {
             copyThemesourceToProject,
             writeVersionAndLicenseToJSActions,
             createModuleMpk,
-            addREADMEOSSToMpk,
             moveModuleToDist
         ]
     });