[WC-3113] Dynamic pagination #1995
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iobuhov
force-pushed
the
WC-3113/dynamic-pagination
branch
from
c56dde1 to
14f1f59
Compare
iobuhov
force-pushed
the
WC-3113/dynamic-pagination
branch
from
14f1f59 to
114f9fc
Compare
r0b1n
reviewed
Dec 9, 2025
| if (values.useCustomPagination === false) { | ||
| hidePropertyIn(defaultProperties, values, "customPagination"); | ||
| } else { | ||
| hidePropertiesIn(defaultProperties, values, ["pagingPosition", "showPagingButtons"]); |
Collaborator
There was a problem hiding this comment.
Do we want to provide the way to set custom pagination position to top/bottom of the grid?
Collaborator
Author
There was a problem hiding this comment.
I remember that we discussed that it will be at the bottom.
| settingsStorageEnabled: isSettingsStorageEnabled(props), | ||
| enableSelectAll: props.enableSelectAll, | ||
| keepSelection: props.keepSelection, | ||
| pagingPosition: props.pagingPosition, |
Collaborator
There was a problem hiding this comment.
This looks like a candidate to go to the pagination config, so we have single responsibility. As well as newly added requestTotalCount and constPageSize, it feels like they can be a responsibility of the pagination config.
What do you think?
Collaborator
Author
There was a problem hiding this comment.
Yeah, agree, if it's not a big work on it I'll change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Refactoring (e.g. file rename, variable rename, etc.)
New feature (non-breaking change which adds functionality)
Description
Add dynamic pagination to datagrid.