test(): split screenshots per device

Author: ablok

detox/detox.config.js

@@ -1,7 +1,13 @@
-exports.ANDROID_SDK_VERSION = 31;
-exports.IOS_SDK_VERSION = 15;
+const ANDROID_SDK_VERSION = 31;
+const ANDROID_DEVICE_TYPE = "pixel";
+const IOS_SDK_VERSION = 15;
+const IOS_DEVICE_TYPE = "iPhone 13 Pro Max";
 
-exports = {
+module.exports = {
+    ANDROID_SDK_VERSION,
+    ANDROID_DEVICE_TYPE,
+    IOS_SDK_VERSION,
+    IOS_DEVICE_TYPE,
     "test-runner": "npx jest",
     "runner-config": `${__dirname}/jest.detox.config.js`,
     apps: {
@@ -19,14 +25,14 @@ exports = {
         ios: {
             type: "ios.simulator",
             device: {
-                type: "iPhone 13 Pro Max",
-                os: `iOS ${this.IOS_SDK_VERSION}`
+                type: IOS_DEVICE_TYPE,
+                os: `iOS ${IOS_SDK_VERSION}`
             }
         },
         android: {
             type: "android.emulator",
             device: {
-                avdName: `EMULATOR_NATIVE_${this.ANDROID_SDK_VERSION}`
+                avdName: `NATIVE_${ANDROID_DEVICE_TYPE}_${ANDROID_SDK_VERSION}`
             }
         }
     },

detox/jest.detox.startup.js

@@ -13,8 +13,8 @@ expect.extend({
     toMatchImageSnapshot(screenshot, options = {}) {
         const { currentTestName } = this;
         const platform = device.getPlatform();
-        const customSnapshotsDir = join(resolve("./"), "image-snapshots", platform);
-        const customDiffDir = join(resolve("./"), "image-snapshots/results", platform);
+        const customSnapshotsDir = join(resolve("./"), "image-snapshots", platform, device.name);
+        const customDiffDir = join(resolve("./"), "image-snapshots/results", platform, device.name);
 
         return toMatchImageSnapshot.call(this, screenshot, {
             customDiffConfig: { threshold: 0.15 },

detox/scripts/helpers.js

@@ -26,7 +26,7 @@ async function downloadFile(url) {
 
 function execCommand(command, ignoreErrorContaining) {
     try {
-        execSync(command, { stdio: "ignore" });
+        execSync(command);
     } catch (error) {
         if (!error.message.includes(ignoreErrorContaining)) {
             throw new Error(error);

detox/scripts/setup-android.js

@@ -1,4 +1,4 @@
-const { ANDROID_SDK_VERSION } = require("../detox.config");
+const { ANDROID_SDK_VERSION, ANDROID_DEVICE_TYPE } = require("../detox.config");
 const { downloadFile, execCommand } = require("./helpers");
 
 main().catch(e => {
@@ -19,7 +19,7 @@ async function main() {
 
     console.log("Creating Android emulator...");
     execCommand(
-        `avdmanager -s create avd -n EMULATOR_NATIVE_${ANDROID_SDK_VERSION} -k 'system-images;android-${ANDROID_SDK_VERSION};google_apis;x86_64' -f -d 'pixel' -c 1000M`
+        `avdmanager -s create avd -n NATIVE_${ANDROID_DEVICE_TYPE}_${ANDROID_SDK_VERSION} -k 'system-images;android-${ANDROID_SDK_VERSION};google_apis;x86_64' -f -d '${ANDROID_DEVICE_TYPE}' -c 1000M`
     );
 
     console.log("Done!");