Skip to content

Commit a3d6178

Browse files
committed
docs: finalize core charts CI evidence
1 parent eca4291 commit a3d6178

1 file changed

Lines changed: 16 additions & 18 deletions

File tree

‎docs/CORE_CHARTS_INTEGRATION_REPORT.md‎

Lines changed: 16 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -78,40 +78,38 @@ The same `termr::test_app(...); pilot$app$run_worker(...)` startup probe against
7878

7979
## H. Platform support and CI
8080

81-
Implementation commit: `08f69319ea156fb307fc7a5523ac6de9cc9e6308` (`feat: integrate native charts`). The [implementation CI run 40354621821](https://github.com/menshikovs/termr/actions/runs/40354621821) created 11 jobs. Nine completed successfully. Ubuntu release and oldrel-1 were cancelled at the job's 45-minute timeout, not by test assertions: both logs end with `The operation was canceled` at 16:43 UTC, about 45 minutes after job start. The release check had just started; oldrel-1 was running `testthat.R`. There were no reported test failures from these cancelled jobs.
81+
Implementation commit: `08f69319ea156fb307fc7a5523ac6de9cc9e6308` (`feat: integrate native charts`). The first [CI run 40354621821](https://github.com/menshikovs/termr/actions/runs/40354621821) created 11 jobs: 9 succeeded, and Ubuntu release plus oldrel-1 were cancelled at the 45-minute job timeout. Their logs show `The operation was canceled` after long cold setup; no test assertion failure was reported before cancellation.
8282

83-
The documentation-only commit `5289e82e148a9da38337388d26466b8945ceed0a` triggered [run 40358189097](https://github.com/menshikovs/termr/actions/runs/40358189097). At 2026-10-26 16:50 UTC, 10 of 11 jobs had completed successfully with no failures. Ubuntu release and oldrel-1 both passed there. Ubuntu devel remained in `setup-r-dependencies`; it had not produced a result yet. Since the only change from the implementation commit was this report, the completed run 2 results apply to the same chart source.
83+
The documentation-only commit `5289e82e148a9da38337388d26466b8945ceed0a` triggered [run 40358189097](https://github.com/menshikovs/termr/actions/runs/40358189097). Ten jobs succeeded; Ubuntu devel passed `R CMD check` and its in-check test suite, then the separate extended suite was cancelled at the 45-minute timeout. Its in-check result was 8,459 passed, 0 failed, 0 warnings, 4 skipped. The run was cancelled, not a test failure.
8484

85-
| Platform / job | Actual result |
85+
The workflow timeout was raised from 45 to 60 minutes in commit `eca42919adc1f18cdcb98eb34ba1c6e6ebdf8e09`. The resulting [CI run 40363141612](https://github.com/menshikovs/termr/actions/runs/40363141612) completed with **11/11 jobs successful, 0 failures, and 0 cancellations**. The Ubuntu oldrel-1 job took 47.6 minutes and completed `R CMD check` plus the extended suite under the new limit, confirming the timeout fix. The timeout change does not skip checks or alter package behavior.
86+
87+
| Platform / job | Run 40363141612 result |
8688
|---|---|
87-
| Ubuntu, R 4.1 | R CMD check and extended suite passed in run 1 and run 2. Check had 2 NOTEs: installed size 5.1 MB and non-standard top-level files. Testthat: 8,459 passed, 0 failed, 0 warnings, 4 skipped. |
88-
| Ubuntu, R release | Run 1 reached the 45-minute job timeout during check startup. Passed R CMD check and extended suite in run 2 with 1 NOTE. Testthat: 8,459 passed, 0 failed, 0 warnings, 4 skipped. |
89-
| Ubuntu, R oldrel-1 | Run 1 reached the 45-minute timeout during testthat. Passed R CMD check and extended suite in run 2 with 1 NOTE. Testthat: 8,459 passed, 0 failed, 0 warnings, 4 skipped. |
90-
| Ubuntu, R devel | Passed R CMD check and extended suite in run 1 with 1 NOTE. Testthat: 8,459 passed, 0 failed, 0 warnings, 4 skipped. Run 2 was still installing dependencies at the status snapshot above. |
91-
| macOS, R release | Passed R CMD check and extended suite in both runs with 1 NOTE. Testthat: 8,459 passed, 0 failed, 0 warnings, 4 skipped. |
92-
| Windows, R release | Passed R CMD check and extended suite in both runs with 1 NOTE. Testthat: 8,452 passed, 0 failed, 0 warnings, 5 skipped. |
89+
| Ubuntu, R 4.1 | Passed R CMD check and extended suite. Check: 2 NOTEs (installed size 5.1 MB; non-standard top-level files). In-check testthat: 8,459 passed, 0 failed, 0 warnings, 4 skipped. |
90+
| Ubuntu, R release | Passed R CMD check and extended suite with 1 NOTE for non-standard top-level files. In-check testthat: 8,459 passed, 0 failed, 0 warnings, 4 skipped. |
91+
| Ubuntu, R oldrel-1 | Passed R CMD check and extended suite with 1 NOTE for non-standard top-level files. In-check testthat: 8,459 passed, 0 failed, 0 warnings, 4 skipped. |
92+
| Ubuntu, R devel | Passed R CMD check and extended suite with 1 NOTE for non-standard top-level files. In-check testthat: 8,459 passed, 0 failed, 0 warnings, 4 skipped. |
93+
| macOS, R release | Passed R CMD check and extended suite with 1 NOTE for non-standard top-level files. In-check testthat: 8,459 passed, 0 failed, 0 warnings, 4 skipped. |
94+
| Windows, R release | Passed R CMD check and extended suite with 1 NOTE for non-standard top-level files. In-check testthat: 8,452 passed, 0 failed, 0 warnings, 5 skipped. |
9395
| R-devel CRAN incoming tarball | `R CMD check --as-cran` passed with 1 NOTE and no ERROR or WARNING. |
9496
| PTY integration | Ubuntu and macOS jobs passed. |
9597
| Windows input regressions | Passed. |
9698
| SQL integration (DBI + SQLite) | Passed. |
9799

98-
The notes were not suppressed. The non-standard top-level note names AGENTS.md, CODE_OF_CONDUCT.md, CONTRIBUTING.md, README.zh-CN.md, and SECURITY.md. The installed-size note appeared on Ubuntu R 4.1. No completed `R CMD check` reported an ERROR or WARNING. The Windows 11 local sandbox processx error 5 was reproduced against installed CRAN termr 1.0.1; hosted Windows lifecycle and process tests passed in CI.
99-
100-
The implementation workflow matrix timeout was increased from 45 to 60 minutes after the two run 1 jobs exhausted the old limit during dependency setup and check execution. This changes only the CI time budget; it does not skip checks or alter package behavior. Validation of that timeout adjustment is pending the next workflow run.
100+
The notes were not suppressed. The non-standard top-level note names AGENTS.md, CODE_OF_CONDUCT.md, CONTRIBUTING.md, README.zh-CN.md, and SECURITY.md. No completed R CMD check reported an ERROR or WARNING. GitHub emitted a separate Node.js 20 deprecation warning for `actions/checkout@v4`; it did not affect job results. The local Windows 11 sandbox processx error 5 was reproduced against installed CRAN termr 1.0.1; hosted Windows subprocess and lifecycle tests passed.
101101

102102
The CRAN termr 1.0.1 API comparison remains positive: all 155 common exports and their formals are unchanged, and exactly five chart exports were added. The original termrcharts source at commit `361556778c7fc6e93a46b485a7cdefd1e5f15231` passed its untouched suite locally; coexistence probes passed in both package attachment orders, all five constructors rendered, and constructor formals match. The dependency graph has no cycle: termr does not depend on termrcharts.
103103

104104
## I. Known limitations
105105

106-
- Ubuntu devel had not completed the second run at the recorded status snapshot. No outcome is inferred for that pending job.
107-
- The R 4.1 installed-size NOTE was not compared with CRAN 1.0.1 under the same R 4.1 runner, so whether that NOTE is newly introduced remains unresolved. It is a NOTE, not an ERROR or WARNING.
108-
- The first run's cold setup exceeded the 45-minute matrix job timeout on two Ubuntu configurations. The longer timeout has not yet been exercised by CI.
109-
- Passing PTY integration jobs are evidence for terminal integration checks, not cross-terminal visual certification of chart appearance. Unicode, color, and chart layout have not been manually compared across terminal emulators.
106+
- R 4.1 reported an installed-size NOTE at 5.1 MB. The CRAN 1.0.1 source was not checked on the same R 4.1 runner, so whether that NOTE is newly introduced is unknown. It is not an ERROR or WARNING and did not fail CI.
107+
- PTY integration passed on Ubuntu and macOS, but no manual cross-terminal visual comparison was performed for chart layout, Unicode, or color rendering.
110108
- Performance measurements are headless and coarse-grained; memory includes package and test harness overhead.
111109
- Box plots and the other excluded termrcharts chart families remain outside this integration.
112110

113111
## J. Release readiness
114112

115-
The five chart widgets and their documented exports are implemented. Local and CI API evidence found no removed or changed CRAN 1.0.1 exports or formals. Original termrcharts compatibility probes and the completed R CMD check/regression jobs on Ubuntu, Windows, and macOS found no confirmed chart regression.
113+
The five chart widgets and their documented exports are implemented. CI passed on Ubuntu (R 4.1, release, oldrel-1, devel), Windows, and macOS; `R CMD check` and the extended regression suite passed without ERROR or WARNING. The earlier 45-minute cancellations were resolved by extending the job timeout to 60 minutes, verified by run 40363141612. CRAN 1.0.1 exports and formals are preserved, and the original termrcharts compatibility probes passed.
116114

117-
**Stage 3B is not yet complete or ready to merge.** The implementation and report runs provide passing evidence across all release platforms, but Ubuntu devel on run 2 and the new 60-minute timeout remain unverified. The R 4.1 installed-size NOTE also remains un-compared against the CRAN baseline on the same runner. Reassess after the pending R-devel job and the timeout-adjusted workflow complete.
115+
**Stage 3B is verified and ready for merge.** No confirmed chart regression or unintended public API change was found. The remaining items are the non-blocking R 4.1 installed-size NOTE and the lack of manual visual comparison across terminal emulators. No merge or CRAN submission was performed.

0 commit comments

Comments
 (0)