-
Notifications
You must be signed in to change notification settings - Fork 137
Open
Description
Situation
Currently variant specific code is spread out between the respective variant folders and the src/helpers
libraries. This make it hard to reason about and work on variants as well as add new variants.
Proposal
We should move all variant specific code to their respective folders and any shared code can stay in the appropriate folder in src/helpers
.
These should be done one at a time and one PR each to make it easy to review. Each PR should also only move files at first, shared code can be moved out after each variant is complete.
Variants to be refactored
- heltec_tracker ^1
- heltec_v2
- heltec_v3 ^1
- heltec_wireless_paper ^1
- lilygo_tbeam ^2
- lilygo_tbeam_SX1262 ^2
- lilygo_tbeam_supreme_SX1262 ^2
- lilygo_tlora_v2_1
- meshadventurer
- minewsemi me25ls01 Clean up Minewsemi ME25LS01 variant #508
- picow
- promicro Clean up Promicro variant #507
- rak4631 move rak4631 specific files into variant folder #506
- station_g2
- t114
- techo
- tenstar c3 ^3
- thinknode_m1
- waveshare rp2040 lora
- xiao_c3 ^3
- xiao_nrf52 cleanup xiao nrf52 #479
Shared code
Some known shared code is listed below. It should be evaluated for any differences from the base board and probably refactored out into build flags and or variant specific code as appropriate.
- ^1 helpers/HeltecV3Board.h
- ^2 helpers/esp32/TBeamBoard.h
- ^3 helpers/XiaoC3Boad.h
recrof, rightup and oltaco
Metadata
Metadata
Assignees
Labels
No labels