Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: The transformHandler function re-subscribes to events on ever chunk of data #116

Open
benbrown opened this issue Nov 22, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@benbrown
Copy link
Contributor

Hardware

Not Applicable

Connection Type

Serial

Firmware Version

2.4.x

Description

This line of code causes an event handler to be subscribed to an event. This occurs on every chunk of data that gets passed, which will likely cause a memory leak over time.

https://github.com/benbrown/meshtastic-js/blob/c6c26f1a153e9d7e5ca0a7bdd4cb8031cce6fff4/src/utils/transformHandler.ts#L16

This should happen outside of the actual chunk handler.

Relevant console output

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant