Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[breaking] move uplink_enabled & downlink_enabled out of ChannelSettings #395

Open
andrekir opened this issue Oct 12, 2023 · 1 comment
Open

[breaking] move uplink_enabled & downlink_enabled out of ChannelSettings #395

andrekir opened this issue Oct 12, 2023 · 1 comment
Labels
3.0 enhancement New feature or request

Comments

@andrekir
Copy link
Member

andrekir commented Oct 12, 2023 •
edited
Loading

https://github.com/meshtastic/protobufs/blob/master/meshtastic/channel.proto#L75-L84

There is no need to have uplink_enabled and downlink_enabled as part of ChannelSettings and ChannelSet since they don't need to be shared with all nodes in a local mesh to be able to communicate.
@thebentern thebentern added the enhancement New feature or request label Oct 13, 2023
@thebentern
Copy link
Contributor

Seems like a good item for the 3.0 project board

@andrekir andrekir changed the title [breaking] move uplink_enabled & downlink_enabled from Channel to MQTT module config [breaking] move uplink_enabled & downlink_enabled out of ChannelSettings Dec 7, 2023
@caveman99 caveman99 added the 3.0 label Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.0 enhancement New feature or request
Projects
Meshtastic 3.0 Goals and Ideas
Status: To-Do
Milestone
No milestone
Development

No branches or pull requests
3 participants
@caveman99 @thebentern @andrekir