don't ask for patchelf if ninja is available and the project is pure

Signed-off-by: Filipe Laíns <[email protected]>

Author: FFY00

mesonpy/__init__.py

@@ -1019,7 +1019,15 @@ def get_requires_for_build_wheel(
         # we may need patchelf
         if not shutil.which('patchelf'):
             # patchelf not already accessible on the system
-            dependencies.append(_depstr.patchelf)
+            if _env_ninja_command() is not None:
+                # we have ninja available, so we can run Meson and check if the project needs patchelf
+                with _project(config_settings) as project:
+                    if not project.is_pure:
+                        dependencies.append(_depstr.patchelf)
+            else:
+                # we can't check if the project needs patchelf, so always add it
+                # XXX: wait for https://github.com/mesonbuild/meson/pull/10779
+                dependencies.append(_depstr.patchelf)
 
     return dependencies
 

tests/test_pep517.py

@@ -37,10 +37,17 @@ def run(cmd: List[str], *args: object, **kwargs: object) -> subprocess.Completed
     monkeypatch.setattr(subprocess, 'run', run)
 
     expected = {mesonpy._depstr.wheel}
-    if system_patchelf is None and sys.platform.startswith('linux'):
-        expected |= {mesonpy._depstr.patchelf}
-    if ninja is None or [int(x) for x in ninja.split('.')] < [1, 8, 2]:
+
+    ninja_available = ninja is not None and [int(x) for x in ninja.split('.')] >= [1, 8, 2]
+
+    if not ninja_available:
         expected |= {mesonpy._depstr.ninja}
 
+    if (
+        system_patchelf is None and sys.platform.startswith('linux')
+        and (not ninja_available or (ninja_available and package != 'pure'))
+    ):
+        expected |= {mesonpy._depstr.patchelf}
+
     with cd_package(package):
         assert set(mesonpy.get_requires_for_build_wheel()) == expected