Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More convenient way of reporting used and total #11

Open
bobrik opened this issue Mar 23, 2016 · 4 comments
Open

More convenient way of reporting used and total #11

bobrik opened this issue Mar 23, 2016 · 4 comments

Comments

@bobrik
Copy link
Contributor

bobrik commented Mar 23, 2016

Currently some metrics are reported like this:

# TYPE mesos_master_cpus gauge
mesos_master_cpus{type="free"} 1924.1
mesos_master_cpus{type="used"} 1579.9

and some like this:

mesos_slave_cpus{slave="slave(1)@1.2.3.4:5051"} 32
mesos_slave_cpus_used{slave="slave(1)@1.2.3.4:5051"} 2.4

I thin we should converge to the second model in a backward compatible fashion. WDYT?

@keis
Copy link

keis commented Mar 23, 2016

👍 for aligning the reporting style. The first seems to be the most common style currently (used by e.g mesos_slave_mem also) but the 2nd feels a bit cleaner imho.

@StephanErb
Copy link
Collaborator

AFAIK, sum and average over the label-dimensions of a metric should make sense. The second approach therefore seems to be the way to go.

Maybe @brian-brazil can enlighten us here :-)

@brian-brazil
Copy link
Contributor

The 2nd way is preferred, as it's easier to work with.

@bobrik
Copy link
Contributor Author

bobrik commented Apr 6, 2016

#8 is open for 2 weeks without attention, not sure if it's worth doing anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants