Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a single HTTP client. #83

Open
jpeach opened this issue Aug 21, 2018 · 0 comments
Open

Use a single HTTP client. #83

jpeach opened this issue Aug 21, 2018 · 0 comments

Comments

@jpeach
Copy link
Contributor

jpeach commented Aug 21, 2018

Normally, the pattern for Go HTTP client code is to use a single global http.Client instance, which lets connection pooling work correctly. Currently in the exporter, we use a HTTP client per collector. To use a global client, we would need to add some locking around the DC/OS auth token state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant