You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We currently lack unit tests for the situation with "more than 1 storm workers being launched in 1 mesos executor". As a result we've made an ugly chain of changes related to supporting this behavior:
PR #65 created a subtle regression where we could never launch more than 1 worker in a given executor (so at most 1 worker process per topology per host).
PR #78 attempted to fix this issue, but also added a new bug, where we subtract executor resources from offers more than necessary.
PR #79 attempted to fix the bug introduced in PR #78, but it introduced another bug (a NullPointerException crash, where after the first pass through the computeResourcesForSlot() main loop, the executorCpuResources and executorMemResources variables are set to null and because subtractedExecutorResources was set to true on the 1st pass).
PR #82 then is attempting to fix the NPE introduced in PR #79.
So we should add a unit test that prevents these kinds of regressions.
The text was updated successfully, but these errors were encountered:
We currently lack unit tests for the situation with "more than 1 storm workers being launched in 1 mesos executor". As a result we've made an ugly chain of changes related to supporting this behavior:
PR #65 created a subtle regression where we could never launch more than 1 worker in a given executor (so at most 1 worker process per topology per host).
PR #78 attempted to fix this issue, but also added a new bug, where we subtract executor resources from offers more than necessary.
PR #79 attempted to fix the bug introduced in PR #78, but it introduced another bug (a NullPointerException crash, where after the first pass through the
computeResourcesForSlot()
main loop, theexecutorCpuResources
andexecutorMemResources
variables are set to null and becausesubtractedExecutorResources
was set to true on the 1st pass).PR #82 then is attempting to fix the NPE introduced in PR #79.
So we should add a unit test that prevents these kinds of regressions.
The text was updated successfully, but these errors were encountered: