Merge pull request #82 from messagebird/hotfix/call-flow-400

Unexpected 400 error when repeat option set in a call flow

Author: dysosmus

api/pom.xml

@@ -4,7 +4,7 @@
 
     <groupId>com.messagebird</groupId>
     <artifactId>messagebird-api</artifactId>
-    <version>3.0.5</version> <!--
+    <version>3.0.6</version> <!--
         are you going to bump a major number?
         then you are pleased to replace com.messagebird.Base64 with some library, for example net.iharder.base64
     -->

api/src/main/java/com/messagebird/objects/VoiceStepOption.java

@@ -10,7 +10,7 @@ public class VoiceStepOption implements Serializable {
     private String payload;
     private String language;
     private String voice;
-    private String repeat;
+    private int repeat;
     private String media;
     private int length;
     private int maxLength;
@@ -57,11 +57,11 @@ public void setVoice(String voice) {
         this.voice = voice;
     }
 
-    public String getRepeat() {
+    public int getRepeat() {
         return repeat;
     }
 
-    public void setRepeat(String repeat) {
+    public void setRepeat(int repeat) {
         this.repeat = repeat;
     }
 

api/src/test/java/com/messagebird/TestUtil.java

@@ -173,7 +173,7 @@ private static VoiceStepOption createVoiceStepOption()
         voiceStepOption.setPayload("Test payload Update");
         voiceStepOption.setLanguage("en-US");
         voiceStepOption.setVoice("female");
-        voiceStepOption.setRepeat("5");
+        voiceStepOption.setRepeat(5);
         voiceStepOption.setMedia("test.wav");
         voiceStepOption.setLength(10);
         voiceStepOption.setMaxLength(20);

api/src/test/java/com/messagebird/VoiceCallFlowTest.java

@@ -236,7 +236,7 @@ private void testVoiceCallFlowAgainstFixture(VoiceCallFlow voiceCallFlow) {
         assertEquals(voiceStepOption.getPayload(), "Test payload");
         assertEquals(voiceStepOption.getLanguage(), "en-GB");
         assertEquals(voiceStepOption.getVoice(), "male");
-        assertEquals(voiceStepOption.getRepeat(), "1");
+        assertEquals(voiceStepOption.getRepeat(), 1);
         assertEquals(voiceStepOption.getMedia(), "test.mp3");
         assertEquals(voiceStepOption.getFinishOnKey(), "1");
         assertEquals(voiceStepOption.getTranscribeLanguage(), "en-GB");

api/src/test/resources/fixtures/call_flow_update_response.json

@@ -12,7 +12,7 @@
             "payload"             : "Test payload",
             "language"            : "en-GB",
             "voice"               : "male",
-            "repeat"              : "1",
+            "repeat"              : 1,
             "media"               : "test.mp3",
             "length"              : 1,
             "maxLength"           : 2,

api/src/test/resources/fixtures/call_flow_view.json

@@ -12,7 +12,7 @@
             "payload"             : "Test payload",
             "language"            : "en-GB",
             "voice"               : "male",
-            "repeat"              : "1",
+            "repeat"              : 1,
             "media"               : "test.mp3",
             "length"              : 1,
             "maxLength"           : 2,

api/src/test/resources/fixtures/call_flows_list.json

@@ -12,7 +12,7 @@
             "payload"             : "Test payload",
             "language"            : "en-GB",
             "voice"               : "male",
-            "repeat"              : "1",
+            "repeat"              : 1,
             "media"               : "test.mp3",
             "length"              : 1,
             "maxLength"           : 2,

api/src/test/resources/fixtures/call_flows_post.json

@@ -12,7 +12,7 @@
             "payload"             : "Test payload",
             "language"            : "en-GB",
             "voice"               : "male",
-            "repeat"              : "1",
+            "repeat"              : 1,
             "media"               : "test.mp3",
             "length"              : 1,
             "maxLength"           : 2,

examples/pom.xml

@@ -6,7 +6,7 @@
 
     <groupId>com.messagebird</groupId>
     <artifactId>examples</artifactId>
-    <version>3.0.5</version>
+    <version>3.0.6</version>
 
     <licenses>
         <license>